Don't stream vid in discovery when not on wifi. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Feb 9, 2017
| self.playVideoUrl.assertValueCount(1) | ||
| self.stopVideo.assertValueCount(0) | ||
|
|
||
| self.reachability.value = .wwan |
There was a problem hiding this comment.
Love how easy this ended up being for testing 😄
|
This is great and makes sense! Super slick too :) |
|
very nice! great suggestion @sarenji |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Let's not do the live streaming in discovery when the user isn't on wifi. This was a point brought up by @sarenji with regards to people with slow internet and people who need to conserve cellular data.
How
We have a
reachabilitysignal producer in the app environment that emits the current value immediately and then any new values as they come. We simply combine this into the signals that control playing/stopping the video and BAM. That easy.Demo