[NT-330] Set initial amount from Backing #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Oct 1, 2019
| private func amountFromBacking(_ backing: Backing?) -> Double? { | ||
| guard let amount = backing?.amount else { return nil } | ||
|
|
||
| return amount - Double(backing?.shippingAmount ?? 0) |
There was a problem hiding this comment.
I think it's usually better when doing arithmetic using money types to use Decimal:
let shippingAmount: Double = backing?.shippingAmount ?? 0
let pledgeAmount = Decimal(amount) - Decimal(shippingAmount)
return (pledgeAmount as NSDecimalNumber).doubleValue
What do you think?
There was a problem hiding this comment.
Hmm yeah good point - although we seem to have been a little inconsistent with this 🤦♂
https://github.com/kickstarter/ios-oss/blob/master/Library/ViewModels/BackingViewModel.swift#L176
But I'll change that here!
1 task
dusi
reviewed
Oct 2, 2019
KsApi/models/BackingTests.swift
Outdated
| let backing = Backing.template | ||
| |> Backing.lens.reward .~ Reward.postcards | ||
| |> Backing.lens.rewardId .~ Reward.postcards.id | ||
| |> Backing.lens.shippingAmount .~ 116 |
There was a problem hiding this comment.
I'd really chose some easier numbers here for better understanding of what's going on in here 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Follow-up to #858, this sets the initial pledge amount to that of the
Backingif it is set in theProject'sPersonalization.✅ Acceptance criteria