Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-410] Handle optional paymentsource #875

Merged
merged 9 commits into from
Oct 7, 2019

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented Oct 4, 2019

📲 What

  • This is a solution created by @justinswart that solves an issue on which Backing model fails deserializing on Staging because some fields of payment_source are not being returned on that environment.

🤔 Why

  • This will allow us to test tasks related to backed projects on Staging until the data is returned normally by the server.
Before 🐛 After 🦋
Simulator Screen Shot - iPhone 8 - 2019-10-04 at 16 02 50 Simulator Screen Shot - Clone 1 of iPhone 8 - 2019-10-04 at 16 01 06

Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

From my conversation with @justinswart on Slack:

  • I'd suggest that tryDecodePaymentSource is only used if we're in DEBUG mode and staging environment is set - just to be double sure this is not going to ship to App Store.
  • Or if that seems too restrictive at least keep a compiler warning on this line to refer back to it soon ¯_(ツ)_/¯

🚢 🚢 🚢
🚢 🚢 🚢
🚢 🚢 🚢

@justinswart justinswart changed the title Handle optional paymentsource [NT-410] Handle optional paymentsource Oct 4, 2019
@Scollaco Scollaco merged commit 723d483 into master Oct 7, 2019
@Scollaco Scollaco deleted the handle-optional-paymentsource branch October 7, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants