Extract reward cell to its own nib #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theginbin
approved these changes
Feb 9, 2017
| @@ -28,6 +28,9 @@ public final class ProjectPamphletContentViewController: UITableViewController { | |||
| self, action: #selector(scrollViewPanGestureRecognizerDidChange(_:)) | |||
| ) | |||
|
|
|||
| self.tableView.register(UINib(nibName: "RewardCell", bundle: Bundle.framework), | |||
| forCellReuseIdentifier: "RewardCell") | |||
There was a problem hiding this comment.
might be nice to put this in a new enum in Storyboard.swift?
theginbin
reviewed
Feb 9, 2017
| extension UITableView { | ||
| public func register(nib: Nib, inBundle bundle: Bundle = .framework) { | ||
| self.register(UINib(nibName: nib.rawValue, bundle: bundle), forCellReuseIdentifier: nib.rawValue) | ||
| } |
There was a problem hiding this comment.
you know how much i love enums
justinswart
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been tinkering with how we can reuse table view cells across multiple controllers/storyboards, and turns out it's very easy. So, I took a shot at doing this for our
RewardCell, which is definitely our most complicated cell. I did this one cause some future work is gonna bring rewards into some new views.To do this I literally just cut+pasted the cell from the storyboard to a brand new
*.xibfile. Then I have to do an explicitself.tableView.register(nib)step in the controller because that's what the storyboard + prototype cell does for you. But after that it just worked!