Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT-328] - Localizations - Min pledge amount label #883

Merged
merged 5 commits into from
Oct 9, 2019
Merged

[NT-328] - Localizations - Min pledge amount label #883

merged 5 commits into from
Oct 9, 2019

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Oct 8, 2019 •
edited
Loading

📲 What

Adds localizations for the min pledge amount label.

🤔 Why

We were missing these translations.

👀 See

🇺🇸 🇩🇪 🇪🇸 🇫🇷 🇯🇵
Screen Shot 2019-10-08 at 2 46 25 PM Screen Shot 2019-10-08 at 2 46 41 PM Screen Shot 2019-10-08 at 2 46 55 PM Screen Shot 2019-10-08 at 2 47 09 PM Screen Shot 2019-10-08 at 2 47 23 PM

♿️ Accessibility

  • VoiceOver reads strings in their respective language

✅ Acceptance criteria

  1. Change language
  2. Navigate to the new pledge screen
  • English shows translated min pledge amount text in the label
  • German shows translated min pledge amount text in the label
  • Spanish shows translated min pledge amount text in the label
  • French shows translated min pledge amount text in the label
  • Japanese shows translated min pledge amount text in the label

@dusi dusi changed the title [] - Localizations - Min pledge amount label [NT-328] - Localizations - Min pledge amount label Oct 8, 2019
@dusi dusi requested a review from cdolm92 October 8, 2019 21:49
@dusi dusi requested a review from Scollaco October 8, 2019 21:49
Scollaco
Scollaco approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚢 🎉

@dusi dusi merged commit 46ed810 into master Oct 9, 2019
@dusi dusi deleted the l10n-min-pledge-amount branch October 9, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

@cdolm92 cdolm92 Awaiting requested review from cdolm92

Assignees

@Scollaco Scollaco

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dusi @Scollaco