-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-226] Cancel Backing Integration #884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦Cancel button on submit
β¦cancel-backing-integration # Conflicts: # Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift # Library/ViewModels/ManagePledgeViewModelTests.swift
β¦cancel-backing-integration
Generated by π« Danger |
β¦cancel-backing-integration # Conflicts: # Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift
justinswart
reviewed
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works well! Minor comments.
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift
Outdated
Show resolved
Hide resolved
justinswart
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Integrates the cancel backing flow with the mutation. Note that this work does not include error handling.
π€ Why
For the cancel backing flow.
π How
CancelBackingMutation
file andCancelBackingInput
file, and adds acancelBacking
function to ourServiceType
cancelPledgeButton
, plus adds handling for dismissing the keyboard on returnNote: the recording didn't properly capture the message banner animation. If you run it on a device the animation is working as expected.
π See
Trello, screenshots, external resources?
βΏοΈ Accessibility
β Acceptance criteria
On staging, back a project that has been created on staging. Then navigate to your backing, and on the Manage Pledge screen navigate to "Cancel your pledge". Enter a cancellation reason. Then tap "Yes, cancel it". You should see in the console that the input parameters for the mutation should include the field "note" with your cancellation reason. You should then be taken back to the project page and you should see the message banner with the message "You've cancelled your pledge.".
Repeat the test above without entering a cancellation reason. Everything should work as expected.