Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-226] Cancel Backing Integration #884

Merged
merged 15 commits into from
Oct 11, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Oct 9, 2019

πŸ“² What

Integrates the cancel backing flow with the mutation. Note that this work does not include error handling.

πŸ€” Why

For the cancel backing flow.

πŸ›  How

  • adds the CancelBackingMutation file and CancelBackingInput file, and adds a cancelBacking function to our ServiceType
  • hooks up the cancel backing mutation to the cancelPledgeButton, plus adds handling for dismissing the keyboard on return
  • sets up delegates to handle when the cancel mutation succeeds
  • adds enabling/disabling behavior for the cancel pledge button

Note: the recording didn't properly capture the message banner animation. If you run it on a device the animation is working as expected.

πŸ‘€ See

Trello, screenshots, external resources?

Cancel Pledge Cancel Pledge Button Disabled
VrGImUty6P SvFIROdfIz

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

βœ… Acceptance criteria

  • On staging, back a project that has been created on staging. Then navigate to your backing, and on the Manage Pledge screen navigate to "Cancel your pledge". Enter a cancellation reason. Then tap "Yes, cancel it". You should see in the console that the input parameters for the mutation should include the field "note" with your cancellation reason. You should then be taken back to the project page and you should see the message banner with the message "You've cancelled your pledge.".

  • Repeat the test above without entering a cancellation reason. Everything should work as expected.

@ksr-ci-bot
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

…cancel-backing-integration

# Conflicts:
#	Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well! Minor comments.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ifbarrera ifbarrera merged commit dc4afac into master Oct 11, 2019
@ifbarrera ifbarrera deleted the cancel-backing-integration branch October 11, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants