Backing screen loading indicator #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
suggested changes
Feb 10, 2017
| |> UIActivityIndicatorView.lens.color .~ .ksr_navy_900 | ||
|
|
||
| _ = self.loadingOverlayView | ||
| |> UIView.lens.backgroundColor .~ UIColor(white: 1.0, alpha: 0.99) |
There was a problem hiding this comment.
we chatted irl about this but i think you can get rid of this since you did it in the storyboard
|
|
||
| self.vm.inputs.viewDidLoad() | ||
|
|
||
| self.loadingOverlayIsHidden.assertValues([false]) | ||
| self.backerPledgeAmountAndDate.assertDidNotEmitValue() |
There was a problem hiding this comment.
we don't need to test the loading outputs in each of our test cases, but instead let's create a separate test case for it.
mbrandonw
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
backing screen now includes activity indicator while fetching for backing info.
