[NT-400] Pledge View attributedString crash fix #900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Fixes a crash on
PledgeViewController
when the devices is rotated or the dynamic type size is changed.π€ Why
Because crashes are bad.
π How
This crash was due to some strange async-like behavior when parsing an html string using:
We're not super sure what's actually the root cause of this issue, since during debugging we were able to see that this call was happening on the main thread. What we observed was that parsing an html string would actually cause a subsequent call to
traitCollectionDidChange
to occur in what would appear to be an infinite loop. Debouncing the trigger to theattributedConfirmationString
function seems to solve the issue, although it seems to possibly be related to a deeper issue with constructing an attributed string with html options.π See
β Acceptance criteria