[NT-438] Create backing with free shipping #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create-backing-free-shipping
justinswart
reviewed
Oct 18, 2019
|
|
||
| let rewardId = reward == Reward.noReward ? nil : reward.graphID | ||
| let pledgeParams | ||
| = formattedPledgeParameters( |
There was a problem hiding this comment.
Can we move this to the same line as let pledgeParams
| let rewardId: String? = updateBackingData.reward.graphID | ||
| let backingId = updateBackingData.backing.graphID | ||
| let (pledgeTotal, rewardId, locationId) = | ||
| formattedPledgeParameters( |
Library/SharedFunctions.swift
Outdated
| @@ -216,3 +216,27 @@ internal func classNameWithoutModule(_ class: AnyClass) -> String { | |||
| .dropFirst() | |||
| .joined(separator: ".") | |||
| } | |||
|
|
|||
| typealias FormattedPledgeParameters = (pledgeTotal: String, rewardId: String?, locationId: String?) | |||
There was a problem hiding this comment.
When I read FormattedPledgeParameters I think about this going through a formatter, I'm wondering if SanitizedPledgeParameters or SanitizedPledgeParams describes what we're doing more accurately?
…create-backing-free-shipping
…kstarter/ios-oss into create-backing-free-shipping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds support for creating a pledge with a reward that has free shipping.
🤔 Why
This was missed during the create backing implementation – often rewards ship for free, so we shouldn't be checking on the cost of shipping being greater than 0.
🛠 How
Also includes the following:
👀 See
Also see the new free shipping summary item on the Apple Pay share sheet.
✅ Acceptance criteria