Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-453] [Investment Day] - Fix ViewModels protocols conformance #903

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

Scollaco
Copy link
Contributor

πŸ“² What

  • Makes viewModels explicitly conform to their respective protocols.

πŸ€” Why

  • As pointed by @dusi , by doing that we avoid classes to access viewModels properties directly, making the access possible strictly by inputs.

πŸ›  How

  • Searched for viewModels failing to follow that pattern and replaces let viewModel = ViewModel() with let viewModel: ViewModelType = ViewModel().

βœ… Acceptance criteria

  • No difference should be notices throughout the app.

Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒 🚒 🚒
🚒 🚒 🚒
🚒 🚒 🚒

@Scollaco Scollaco merged commit c38f422 into master Oct 21, 2019
@Scollaco Scollaco deleted the fix-viewmodels-protocol-conformance branch October 21, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants