Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-498] Prevent app freezing with accessibility inspector #922

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Oct 31, 2019

πŸ“² What

Fixes a app-freezing bug in the simulator when adjusting text size using the accessibility inspector in Manage pledge views.

πŸ€” Why

Although this didn't appear to be happening on device we do often adjust text sizes with the inspector and this affects our development workflow. Also this seemed to point out something problematic in the layout and warranted further investigation.

πŸ›  How

  • Added a guard clause to prevent calculating the thumbnail size when PledgeDescriptionViewController is hidden.

We hide PledgeDescriptionViewController when we are in any of the Manage pledge flows other than Choose another reward. When this view is hidden it's not necessary to try to calculate the thumbnail size.

βœ… Acceptance criteria

  • Run the app in simulator on master. Navigate to Update pledge on a project that you've backed. Open the accessibility inspector and adjust text sizes, the app should freeze.
  • Check out this branch and repeat the steps above, the app should not freeze in any of the Manage pledge views.

Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! πŸ›³πŸ›³πŸ›³

@justinswart justinswart merged commit 3aa68d3 into master Oct 31, 2019
@justinswart justinswart deleted the fix-app-freezing-manage-pledge-views branch October 31, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants