[NT-515] Rewards Carousel Creator View #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
approved these changes
Nov 4, 2019
| @@ -115,6 +115,8 @@ private func backingReward(fromProject project: Project) -> Reward? { | |||
| } | |||
|
|
|||
| private func pledgeButtonTitle(project: Project, reward: Reward) -> String? { | |||
| guard !currentUserIsCreator(of: project) else { return nil } | |||
There was a problem hiding this comment.
I often find that using guards when the condition is negated is a little counter intuitive. Should we consider using if?:
if currentUserIsCreator(of: project) { return nil }
ksr-ci-bot
reviewed
Nov 4, 2019
| self.pledgeButtonTitleText.assertValueCount(self.allRewards.count) | ||
|
|
||
| self.gradientViewHidden.assertValues([false, false, false, false, false, false, false, false]) | ||
| self.pledgeButtonStyleType.assertValues([.green, .green, .green, .green, .green, .green, .green, .green]) |
There was a problem hiding this comment.
| 🚫 | Line should be 110 characters or less: currently 111 charactersline_length RewardCardContainerViewModelTests.swift:206 |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This makes the necessary changes to the rewards carousel for when a creator might be viewing their own project.
🤔 Why
Currently they would see their own rewards as a normal backer but things would fail when they tried to pledge against their own project. Instead we're showing them a read only state of their rewards to improve this experience.
🛠 How
func currentUserIsCreator(of project: Project) -> Boolfor determining whether the current user is a creator of a particular project.RewardCardContainerViewModelto hide theSelectbutton when a creator is viewing the rewards.RewardsCollectionViewModelto return a title ofView your rewardsfor the view when a creator is viewing it.👀 See
✅ Acceptance criteria
Create a project using your user on staging.
⏰ TODO