[NT-482] Pledge tracking events #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pledge-tracking-events
…pledge-tracking-events
cdolm92
commented
Nov 5, 2019
| .observeValues { | ||
| AppEnvironment.current.koala.trackAddNewCardButtonClicked( | ||
| project: $0, pledgeAmount: $1?.amount ?? 0.0 | ||
| ) |
There was a problem hiding this comment.
Refactor this so it does not emit when user is changing payment method.
| XCTAssertEqual([], self.trackingClient.events) | ||
|
|
||
| self.vm.inputs.addNewCardTapped(with: .pledge) | ||
| self.goToAddCardIntent.assertValues([.pledge]) |
There was a problem hiding this comment.
Remove this, we are only testing the event
| let projectAndBacking = Signal.combineLatest(project, backing) | ||
|
|
||
| // Tracking | ||
| projectAndBacking |
| func testTrackingEvents_PledgeScreenViewed() { | ||
| self.vm.inputs.configureWith(project: .template, reward: .template, refTag: nil, context: .pledge) | ||
|
|
||
| self.vm.inputs.viewDidLoad() |
There was a problem hiding this comment.
Test that event does not emit
|
|
||
| func testTrackingEvents_PledgeButtonClicked() { | ||
| self.vm.inputs.configureWith(project: .template, reward: .template, refTag: nil, context: .pledge) | ||
| self.vm.inputs.viewDidLoad() |
…pledge-tracking-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Improvements in monitoring user behavior for v1 checkout. This tracks events in the pledge screen.
🤔 Why
We now track the following events on the pledge screen:
Pledge Screen ViewedPledge Button ClickedAdd New Card Button Clicked✅ Acceptance criteria
Pledge Screen Viewed: Navigate to a live/non-backed project, tapBack this project-> select a reward, pledge screen should load and you should the event emit.Pledge Button Clicked: Navigate to a live/non-backed project, tapBack this project-> select a reward, and then tapPledge. You should see the event emit.Pledge Button Clicked: Navigate to a live/non-backed project, tapBack this project-> select a reward, and then tapAdd New Card. Add New Card should load and you should see event emit.