[NT-505] Project page creators header #930

Scollaco · 2019-11-04T21:57:29Z

📲 What

Adds a header to allow the creator to easily see dashboard/progress of the project she/he created.
Note: This PR doesn't handle the case when contributors visit the project page. This will be done in the future.

🤔 Why

This task is the first part of a series of tickets that will prevent creators of backing their own project.

🛠 How

Created ProjectPamphletCreatorHeaderCell and its viewModel.
Created ProjectPamphletCreatorHeaderCellDelegate to notify the ProjectPamphletContentViewController when the user taps the View progress/dashboard button.
The top margin on the Video storyboard was a little off and it was preventing the cell to be presented correctly.
Added translations
Added tests for viewModel, dataSource, and viewController.

👀 See

Non Creator 🐛	Creator 🦋

♿️ Accessibility

Tap targets use minimum of 44x44 pts dimensions
Works with VoiceOver
Supports Dynamic Type

✅ Acceptance criteria

** Logged-in using the therealnativesquad account:

Select any non-created project from Discovey. The header should be hidden.
Search for a project created using that account (e.g Help me transform this pile of wood and select it. The Project page should be presented with the header containing a label indicating when the project was created and a button showing View progress if project is live or View dashboard if project is no longer live.

…header

Scollaco · 2019-11-04T21:58:50Z

Kickstarter-iOS/Views/Storyboards/ProjectPamphlet.storyboard

@@ -19,7 +19,7 @@
                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                        <subviews>
                            <containerView opaque="NO" contentMode="scaleToFill" insetsLayoutMarginsFromSafeArea="NO" translatesAutoresizingMaskIntoConstraints="NO" id="tIm-aj-d8Q">
-                                <rect key="frame" x="0.0" y="52" width="400" height="1348"/>
+                                <rect key="frame" x="0.0" y="55" width="400" height="1346"/>


Had to move the ProjectPamphletContent container down a little bit because it was overlapping the top cell.

ksr-ci-bot · 2019-11-06T15:23:44Z

	1 Warning
⚠️	Big PR

SwiftFormat found issues:

File	Rules
Kickstarter-iOS/Views/Cells/ProjectPamphletCreatorHeaderCell.swift	anyObjectProtocol

Generated by 🚫 Danger

Scollaco · 2019-11-06T16:00:49Z

Kickstarter-iOS/Views/Cells/ProjectPamphletCreatorHeaderCell.swift

+  )
+}
+
+final class ProjectPamphletCreatorHeaderCell: UITableViewCell, ValueCell {


Still not sure about this name 🤔 Would ProjectPamphletViewProgressCell be better?

ifbarrera

Couple questions/comments but looks good!

ifbarrera · 2019-11-06T16:04:12Z

Library/ViewModels/ProjectPamphletCreatorHeaderCellViewModel.swift

+
+private func attributedLaunchDateString(with project: Project)
+  -> NSAttributedString? {
+  let date = Format.date(secondsInUTC: project.dates.launchedAt, dateStyle: .long, timeStyle: .none)


We might want to pass a timezone of UTC to this date formatter so that the date doesn't get converted to the device's timezone? 🤔

ifbarrera · 2019-11-06T16:08:55Z

Library/ViewModels/ProjectPamphletCreatorHeaderCellViewModelTests.swift

+  }
+
+  func testLaunchDateLabelAttributedText() {
+    let project = Project.template


Can we set the .launchedAt variable on the project to a date we've defined so we can see that it's actually displaying the correct date? Otherwise this test feels a little hand-wavey.

Thats a good idea!

I meant more something like:

// Set the date to Nov 1, 2019 let dateComponents = DateComponents() |> \.month .~ 11 |> \.day .~ 1 |> \.year .~ 2_019 |> \.timeZone .~ TimeZone.init(secondsFromGMT: 0) let date = AppEnvironment.current.calendar.date(from: dateComponents) let project = Project.template |> \.dates.launchedAt .~ date.timeIntervalSince1970 ... // Assert that the date is Nov 1, 2019, which is the date you set in the "launchedAt" property self.launchDateLabelAttributedText.assertValue("You launched this project on November 1, 2019.")

You might also want to set the locale in withEnvironment to ensure that the date is always formatted in the same way.

justinswart · 2019-11-05T20:54:50Z

Kickstarter-iOS/DataSources/ProjectPamphletContentDataSource.swift

@@ -4,6 +4,7 @@ import Prelude

 internal final class ProjectPamphletContentDataSource: ValueCellDataSource {
  internal enum Section: Int {
+    case viewProgress


I think I'd name this a little closer to the cell it represents, maybe creatorHeader?

justinswart · 2019-11-06T17:35:08Z

Kickstarter-iOS/Views/Cells/ProjectPamphletCreatorHeaderCell.swift

+
+private enum Layout {
+  enum Button {
+    static let height: CGFloat = 48


Where are these constants from?

This comes from Abstract.

…kstarter/ios-oss into project-page-creators-header

ifbarrera

We might want to increase the stack view spacing, it looks a little tight on iPhone 5s:

ifbarrera · 2019-11-07T16:01:47Z

Kickstarter-iOS/Views/Cells/ProjectPamphletCreatorHeaderCell.swift

+
+    self.viewModel.outputs.notifyDelegateViewProgressButtonTapped
+      .observeForUI()
+      .observeValues { [weak self] in


Can we name the argument here? We typically name them when observing the values in bindViewModel to make it clear what the value is.

ifbarrera · 2019-11-07T16:08:32Z

Library/ViewModels/ProjectPamphletCreatorHeaderCellViewModelTests.swift

+  }
+
+  func testLaunchDateLabelAttributedText() {
+    let project = Project.template


I meant more something like:

// Set the date to Nov 1, 2019 let dateComponents = DateComponents() |> \.month .~ 11 |> \.day .~ 1 |> \.year .~ 2_019 |> \.timeZone .~ TimeZone.init(secondsFromGMT: 0) let date = AppEnvironment.current.calendar.date(from: dateComponents) let project = Project.template |> \.dates.launchedAt .~ date.timeIntervalSince1970 ... // Assert that the date is Nov 1, 2019, which is the date you set in the "launchedAt" property self.launchDateLabelAttributedText.assertValue("You launched this project on November 1, 2019.")

You might also want to set the locale in withEnvironment to ensure that the date is always formatted in the same way.

ifbarrera

lgtm!

Scollaco added 17 commits November 1, 2019 11:14

Created ProjectPamphletCreatorHeaderCell

c92be4f

Fixed top margin, added border

83dba29

Added viewModel and logic to show the text according to project state

e71d473

Added delegate

5d6afe8

Added tests

9eb8a4e

Added viewcontroller test

283c0f3

Merge remote-tracking branch 'oss/master' into project-page-creators-…

588bdfa

…header

Strings

8f2a20c

Replaces hardcoded strings

51a74ca

Added missing viewController test

2032902

Merge remote-tracking branch 'oss/master' into project-page-creators-…

0f4bfc4

…header

Added DataSource tests and generated snapshots

fde2f35

Swiftformat

be5763f

Fixed video container top margin

88609a7

Snapshots

2edc779

Removed recordMode line

34e0f07

Removed print function

ef91760

Scollaco requested review from ifbarrera and justinswart November 4, 2019 21:57

Scollaco assigned ifbarrera Nov 4, 2019

Scollaco commented Nov 4, 2019

View reviewed changes

Fixed margins and navBar height

920c913

Scollaco added 3 commits November 6, 2019 10:26

Updated snapshots

0317c0e

SwiftFormat

20d7ca1

Merge branch 'master' into project-page-creators-header

bd1f320

Scollaco commented Nov 6, 2019

View reviewed changes

ifbarrera reviewed Nov 6, 2019

View reviewed changes

justinswart reviewed Nov 6, 2019

View reviewed changes

Pass timezone on date format function

7dad6ff

Scollaco added 4 commits November 6, 2019 18:00

SwiftFormat

8678939

Merge branch 'project-page-creators-header' of https://github.com/kic…

6b266d5

…kstarter/ios-oss into project-page-creators-header

Merge branch 'master' into project-page-creators-header

88b3d41

Merge branch 'master' into project-page-creators-header

6bb7351

ifbarrera reviewed Nov 7, 2019

View reviewed changes

Added spacing to stackView, fixed data used on tests

832e145

ifbarrera approved these changes Nov 7, 2019

View reviewed changes

Scollaco merged commit f4800ce into master Nov 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NT-505] Project page creators header #930

[NT-505] Project page creators header #930

Scollaco commented Nov 4, 2019 •

edited

Loading

Scollaco Nov 4, 2019

ksr-ci-bot commented Nov 6, 2019 •

edited

Loading

Scollaco Nov 6, 2019

ifbarrera left a comment

ifbarrera Nov 6, 2019

ifbarrera Nov 6, 2019

Scollaco Nov 6, 2019

ifbarrera Nov 7, 2019

Scollaco Nov 7, 2019

justinswart Nov 5, 2019

justinswart Nov 6, 2019

Scollaco Nov 6, 2019

ifbarrera left a comment

ifbarrera Nov 7, 2019

ifbarrera Nov 7, 2019

ifbarrera left a comment

[NT-505] Project page creators header #930

[NT-505] Project page creators header #930

Conversation

Scollaco commented Nov 4, 2019 • edited Loading

📲 What

🤔 Why

🛠 How

👀 See

♿️ Accessibility

✅ Acceptance criteria

Choose a reason for hiding this comment

ksr-ci-bot commented Nov 6, 2019 • edited Loading

SwiftFormat found issues:

Choose a reason for hiding this comment

ifbarrera left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ifbarrera left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ifbarrera left a comment

Choose a reason for hiding this comment

Scollaco commented Nov 4, 2019 •

edited

Loading

ksr-ci-bot commented Nov 6, 2019 •

edited

Loading