[NT-513] Project page creators header navigation #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project-page-creators-header-navigation
Scollaco
commented
Nov 6, 2019
| @@ -186,7 +186,8 @@ public final class RootTabBarViewController: UITabBarController { | |||
| private func viewControllerAndParam<T, P>(with index: RootViewControllerIndex, param: P) -> (T, P)? { | |||
| guard | |||
| let vcs = self.viewControllers, | |||
| let vc = vcs[clamp(0, vcs.count - 1)(index)] as? T | |||
| let nav = vcs[clamp(0, vcs.count - 1)(index)] as? UINavigationController, | |||
There was a problem hiding this comment.
The self.viewControllers is actually an array of UINavigationController. Now we first try to cast to UINavigationController and then cast the viewController to whichever type it is.
This was breaking the navigation to the dashboard when trying to navigate to it through deeplink.
ifbarrera
approved these changes
Nov 7, 2019
| @@ -11,9 +11,9 @@ private enum Layout { | |||
| } | |||
|
|
|||
| protocol ProjectPamphletCreatorHeaderCellDelegate: class { | |||
| func projectPamphletCreatorHeaderCellDidTapButton( | |||
| func projectPamphletCreatorHeaderCell( | |||
There was a problem hiding this comment.
I would rename this to something like projectPamphletCreatorHeaderCellDidTapViewProgress(_ cell: ProjectPamphletCreatorHeaderCell, with project: Project)
There was a problem hiding this comment.
Good suggestion! I will change that.
…project-page-creators-header-navigation
SwiftFormat found issues:
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
View progressbutton on theProjectPamphletContentViewControllerto the dashboard.🤔 Why
JIRA ticket
🛠 How
ProjectPamphletContentViewControllerwhen the creator taps theView progressbutton.RootTabBarViewControllerthat was trying to cast UINavigationController to a generic typeT. This was causing the guard statement to fail making the Dashboard present showing the wrong project.👀 See
✅ Acceptance criteria
Help me transform this pile of wood)View dashboard. The ProjectPage should dismiss and the Dashboard should be presented with the selected project.