[NT-557] Hide "Other payment methods" label when Apple Pay button is hidden #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding on this based on our Slack convo. |
…NT-557-hide-cards-header # Conflicts: # Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift
…NT-557-hide-cards-header
ifbarrera
added
needs review
and removed
blocked
justinswart
approved these changes
Nov 13, 2019
| @@ -95,10 +96,14 @@ final class PledgePaymentMethodsViewController: UIViewController { | |||
| |> checkoutBackgroundStyle | |||
|
|
|||
| _ = self.rootStackView | |||
| |> rootStackViewStyle | |||
| |> verticalStackViewStyle | |||
There was a problem hiding this comment.
Not sure what the point of this style is, I see we've had it for a while but it just sets the axis to vertical 🤷♂
| |> \.isLayoutMarginsRelativeArrangement .~ true | ||
| |> \.layoutMargins .~ UIEdgeInsets(leftRight: CheckoutConstants.PledgeView.Inset.leftRight) | ||
| |> \.layoutMargins .~ .init(leftRight: Styles.grid(4)) |
…NT-557-hide-cards-header
…rter/ios-oss into NT-557-hide-cards-header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Hides the "Other payment methods" label above stored cards when the Apple Pay button is hidden.
🤔 Why
It's a bit strange to say "Other" payment methods when there is only one type of payment method available to the user.
🛠 How
Hiding the label when the Apple Pay button is hidden.
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria