[NT-497] Ensure payment methods scroll edge-to-edge #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
approved these changes
Nov 12, 2019
| private let nestedStackViewStyle: StackViewStyle = { stackView in | ||
| stackView | ||
| |> checkoutRootStackViewStyle | ||
| |> \.layoutMargins .~ UIEdgeInsets(leftRight: CheckoutConstants.PledgeView.Inset.leftRight) |
There was a problem hiding this comment.
checkoutRootStackViewStyle already has a leftRight margin inset of Styles.grid(4) 🤔 not sure you need this nestedStackViewStyle then...
There was a problem hiding this comment.
This is to remove the top and bottom insets 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Restructures our
UIStackViewhierarchies to allow the payment methods to scroll edge-to-edge.🤔 Why
The experience isn't currently correct in that the views are being clipped by the parent
UIStackView.🛠 How
Restructed the view hierarchy so that insets are now applied to child stackviews rather than the parent, this allows us to not set any insets for the stackview containing the payment methods scrollview.
👀 See
✅ Acceptance criteria