Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-456] Apple pay voice over #942

Merged
merged 6 commits into from
Nov 13, 2019
Merged

[NT-456] Apple pay voice over #942

merged 6 commits into from
Nov 13, 2019

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented Nov 12, 2019

📲 What

  • Fixed Accessibility (voice over) on the cardNumberLabel, to make it clear if a project was backed using one of these 2 forms of payment.

🤔 Why

  • To improve the experience of visually impaired users.

JIRA ticket

🛠 How

  • Creating a new property accessibilityLabel on the PaymentType enum.
  • Pre-pending the value of the property to the cardNumberAccessibilityLabel string if the payment was made using either ApplePay or GooglePay.

♿️ Accessibility

  • Works with VoiceOver

✅ Acceptance criteria

With VoiceOver enabled , select a backed project, go to the ManagePledge screen, and tap the Ending in XXXX label.

  • If the project was backed using credit card, VoiceOver should say [Card issuer], ending in [Card number]
  • If the project was backed using ApplePay, VoiceOver should say Apple Pay, [Card issuer], ending in [Card number]
  • If the project was backed using Android/Google Pay, VoiceOver should say Google Pay, [Card issuer], ending in [Card number]

case .googlePay:
return "Google Pay"
case .creditCard:
return nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If PaymentType is .creditCard, voice over doesn't need to say anything.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@justinswart justinswart merged commit 7c6b47b into master Nov 13, 2019
@justinswart justinswart deleted the apple-pay-voice-over branch November 13, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants