[NT-570] Update Fastlane, fix command in circle config #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed this is currently failing on Circle because of the ruby version:
|
ifbarrera
approved these changes
Nov 14, 2019
justinswart
added a commit
that referenced
this pull request
Nov 19, 2019
* Update fastlane, rename command * Add .ruby-version file * Fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates Fastlane and its plugins to suppress some gem security warnings on our repo. Also renames the command
itunes_match_gym_deliver_appcenter->itunes_match_gym_deliverin.circleci/config.ymlso that it matches what we have in our Fastfile.🤔 Why
Our app store builds were failing due to the command name being incorrect.
🛠 How
bundle update fastlanebundle exec fastlane update_plugins👀 See
CircleCI error:
✅ Acceptance criteria
Fastfileand we're able to submit builds to the app store viamake deploy.