[NT-573] Pull to refresh functionality on the Manage/View Pledge screen #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
approved these changes
Nov 19, 2019
| self.viewModel.outputs.endRefreshing | ||
| .observeForUI() | ||
| .observeValues { [weak self] in | ||
| self?.rootScrollView.refreshControl?.endRefreshing() |
There was a problem hiding this comment.
I guess this could reference self.refreshControl directly 🤷♂ - or seeing as we don't customize it and are able to refer to it through the scrollView we could just set it on the scrollView and not have a property referencing it. Up to you.
| @@ -294,6 +311,10 @@ final class ManagePledgeViewController: UIViewController, MessageBannerViewContr | |||
| self.viewModel.inputs.menuButtonTapped() | |||
| } | |||
|
|
|||
| @objc private func handleRefreshControl() { | |||
There was a problem hiding this comment.
Could just be refresh() or beginRefresh()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds a
UIRefreshControlto support pull-to-refresh functionality on the Manage/View pledge screen.🤔 Why
So that users have a way to refresh the screen and get the most up to date information regarding their backing.
🛠 How
UIRefreshControlto the root scroll view.valueChangedaction on theUIRefreshControlto fetching an updated project in the view model👀 See
🏎 Performance
N/A
✅ Acceptance criteria