Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-577] Unavailable Card Selection Fix #957

Merged
merged 6 commits into from
Nov 20, 2019

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Nov 19, 2019

πŸ“² What

When the first card is an unavailable card, it should not be selected and the Pledge button should appear disabled.

πŸ€” Why

Before the pledge button was enabled even when the first card was unavailable and therefore disabled.

πŸ›  How

We check to see if the first card is an available card type before selection.

πŸ‘€ See

Trello, screenshots, external resources?

Before πŸ› After πŸ¦‹
Simulator Screen Shot - iPhone Xs - 2019-11-19 at 17 18 56 Simulator Screen Shot - iPhone Xs - 2019-11-19 at 17 16 44

βœ… Acceptance criteria

  • Navigate to the pledge screen to back a project. If you have an unavailable card listed first you the pledge button should be disabled

Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to cover this case?

Library/ViewModels/PledgePaymentMethodsViewModel.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚒 🚒 🚒 🚒

@cdolm92 cdolm92 merged commit 52fa8f7 into master Nov 20, 2019
@cdolm92 cdolm92 deleted the pledge-screen-unavailable-card-selection-correction branch November 20, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants