Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-565] Limit menu options when backing is on preauth state #960

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented Nov 20, 2019

πŸ“² What

  • Handles the case when the backing on the ManagePledgeViewController is on a .preauth state.
  • The top right menu now can only show Contact creator.

πŸ€” Why

  • Users shouldn't be allowed to manage pledge when the backing is on the .preauth state.
    JIRA ticket

πŸ›  How

  • By changing the logic of the signal that determines which options should be available on the menu.

πŸ‘€ See

.pledged state πŸ› .preauth state πŸ¦‹
Simulator Screen Shot - iPhone 8 - 2019-11-20 at 16 27 38 Simulator Screen Shot - iPhone 8 - 2019-11-20 at 16 29 50

βœ… Acceptance criteria

The easiest way to test this is by using Charles and adding a breakpoint to edit the response from the /v1/projects/ endpoint. (On the Project Page).

  • Back a project and go to the ManagePledgeViewController. The status label should say If the project reaches its funding goal, you will be charged on [date] and the top right menu should show all the options to edit pledge.
  • Using Charles, change the backing.status value to preauth. The status label should say We're processing your pledge--pull to refresh and the top right menu should show only Contact creator.

@Scollaco Scollaco merged commit bbb2266 into master Nov 25, 2019
@Scollaco Scollaco deleted the NT-565-preauth-state-sca-backings branch November 25, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants