[NT-582] Go Rewardless Prompt #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/ios-oss into feature-go-rewardless
* Adding DiscoveryEditorialCell * Adding editorial color * Tests * Add DiscoveryEditorialViewModel * Updating tests * Adding asset * Adding feature flag logic & updating onboarding screenshots * Pass the tag through * Pass refTag through * DiscoveryEditorialViewModelTests * Strings * Screenshot tests, tweaking layout * Voice over accessibility values * Formatting * Styling * Don’t use keypaths
* WIP * Fix header offset issue * Revert changes no longer needed * Revert style change * Add tests * Use Go Rewardless tag ID * Update arbitrary height value for fun * Use magic sort * Remove redundant clear colour and add a11y strings * Fix snapshots * Remove comment
…l header (#967) * Hook onto config for updated FF, and only show header on default params * Post notification on FeatureFlagsViewController with updated feature flags * Observe changes in the config and updates to the filters * View model tests * Update screenshot tests * Formatting * More VM tests * Converting to value struct and adding more tests * Formatting * Linting * Add debouncing * Cleanup * Use compactMap
* Editorial navigation flow * Update RefTag * Instantiate refTag with tagId directly
* Add label and image to modal header * Snapshot tests * Remove a11y traits * Fix snapshots
* Go rewardless carousel treatment * Tests * Formatting * Remove unused helper function * ensuring configureBaseGradientView always emits * formatting * Swiftlint
* Editorial header tracking * Formatting * Filter out android flags * Fixing based on updates from main branch
* Add view transforms, tint colour when scrolling * Formatting * Fix snapshots * Set only tint color of button image, simplify signals * Removed closure, added delegate, added tests * Use large image on ipad * Fix test
* Add view transforms, tint colour when scrolling * Formatting * Fix snapshots * Hide login tout on project collections * Don't show activities on editorials * Fix calculation * Remove line from merge
* Add view transforms, tint colour when scrolling * Formatting * Fix snapshots * Strings * Adding table view header * VM tests and updating screenshots * Updating screenshots broken by updated arrow * Dynamic type support * Screenshots again * Formatting * Be gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
All of the collective work from #958, #961, #962, #965, #966, #967, #969, #970, #971, #973 to bring the Go Rewardless prompt to the app.
🤔 Why
The Backings Pod is kicking off our first ever backer-facing prompt as an experiment to see if we can impact backer behavior with an in-app campaign.
🛠 How
See linked PRs.
👀 See