[NT-643] Remove 1Password extension #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os-oss into drop-ios11-support
…os-oss into drop-ios11-support
# Conflicts: # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_de_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_de_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_de_device_phone4inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_de_device_phone5_5inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_de_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_en_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_en_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_en_device_phone4inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_en_device_phone5_5inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_en_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_es_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_es_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_es_device_phone4inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_es_device_phone5_5inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_es_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_fr_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_fr_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_fr_device_phone4inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_fr_device_phone5_5inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_fr_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_ja_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_ja_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_ja_device_phone4inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_ja_device_phone5_5inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.PaymentMethodsViewControllerTests/testView_WithCreditCards_lang_ja_device_phone5_8inch@2x.png
Generated by 🚫 Danger |
ifbarrera
reviewed
Dec 2, 2019
ifbarrera
approved these changes
Dec 3, 2019
# Conflicts: # Library/SharedFunctions.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
As identified in #904 we no longer need the 1Password extension.
Note: This should merge after #904 and is based off that branch.
🤔 Why
This functionality is provided by iOS 12's Password AutoFill feature.
🛠 How
Removed 1Password extension and all references to it.
✅ Acceptance criteria
The impact of this should be minimal as we previously disabled 1Password on iOS 12.