[NT-645] Clean discovery properties & events [Part 1] #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
…NT-645-clean-discover-properties
justinswart
approved these changes
Dec 9, 2019
| public func trackDiscoveryPullToRefresh() { | ||
| self.track(event: "Triggered Refresh") | ||
| public func trackEditorialHeaderTapped(refTag: RefTag) { | ||
| self.track(event: "Editorial Card Clicked", properties: ["ref_tag": refTag.stringTag]) |
There was a problem hiding this comment.
Should this not include Discover Properties? Like:
discoveryProperties(from: params).withAllValuesFrom(["ref_tag": refTag.stringTag])There was a problem hiding this comment.
I don't think its really useful in this case because the next event should be Collection Viewed which does include discover properties 🤷♀
Library/Tracking/Koala.swift
Outdated
|
|
||
| private func discoveryProperties( | ||
| from params: DiscoveryParams, | ||
| prefix _: String = "discover_" |
There was a problem hiding this comment.
This seems unused in this function, do we want to use it on line 2194?
| @@ -198,3 +198,25 @@ extension RefTag: Argo.Decodable { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension RefTag { | |||
| public static func fromParams(_ params: DiscoveryParams) -> RefTag { | |||
There was a problem hiding this comment.
Now that this is extracted from the VM we probably want to add a test for it.
Scollaco
pushed a commit
that referenced
this pull request
Dec 13, 2019
* WIP cleaning up discovery properties * Cleaning up events * Updating tests * Formatting * Reverting scheme change * Line length * Remove category_projects_count prop * Updates * Formatting * Cleanup * Formatting * RefTag fromParams tests and snake-casing search term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Part 1 of cleaning up our discovery, search, and activities events and properties.
🤔 Why
We're doing some cleanup of our events.
🛠 How
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria
When testing, be sure to enable
KOALA_TRACKINGin the Kickstarter-iOS scheme.Explore Page Viewedfires anytime a new discovery page is viewed. It should not fire on pagination.Explore Sort Clickedfires any time a sort is tapped (Ending soon, Popular, etc).Activity Feed Viewedfires any time a logged in user views their activity feed. It should not fire on pagination.Editorial Card Clickedfires if an editorial card (ex. Go rewardless) is tapped.Collection Viewedfires when an editorial collection of projects is viewed (ex. "Go rewardless")Filter Clickedfires when a category from the Explore dropdown is selectedSearch Page Viewedfires when the search tab is viewedSearch Results Loadedfires after entering a search query when results have loadedDefault discovery properties should include the following properties:
discover_recommendeddiscover_socialdiscover_staff_picksdiscover_starreddiscover_tagdiscover_everythingdiscover_sortdiscover_ref_tagsearch_termdiscover_category_iddiscover_category_namediscover_parent_category_iddiscover_parent_category_name