Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-707] Naming changes and white-listing clean events #995

Merged
merged 13 commits into from
Dec 17, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Dec 16, 2019

📲 What

Updates some of the naming of certain props to reflect latest changes from insights team. Also adds white-listing on "clean" events, so that only white-listed events are sent to the data lake.

🤔 Why

More event cleanup and ensuring that only clean events go to the data lake.

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

Testing white-listing:

  • Ensure that KOALA_TRACKING_ENABLED is set to true, then run the app. On app launch, you should see the event App Open track on the Koala client. You should not see it track on the data lake client.
  • Navigate to a project page. You should the event Project Page Viewed track on both the Koala and Lake clients

Testing discovery props changes:

  • navigate to a subcategory on discovery (ex. Ceramics). On the Explore Page Viewed event, you should see:
    • the property discover_category_name, and it should say Art (the parent category)
    • the property discover_subcategory_name and it should say Ceramics (the current category)
    • the properties discover_category_id and discover_subcategory_id
  • navigate to the "Projects We Love" filter. the Explore Page Viewed event should fire with a property discover_pwl: true
  • navigate to the "Saved" filter. The Explore Page Viewed event should fire with a property discover_watched: true

@@ -2127,39 +2135,6 @@ private func projectProperties(
.prefixedKeys(prefix)
}

private func properties(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was almost completely redundant with projectProperties. Any actually unique props were moved up to the actual tracking function.


self.vm.inputs.viewDidAppear()

XCTAssertEqual(["Viewed Account"], koalaClient.events)
XCTAssertEqual(["Viewed Account"], dataLakeClient.events)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this test anymore since we're testing white-listing events now.

@nativeksr
Copy link
Collaborator

nativeksr commented Dec 16, 2019

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - will test it further, had some minor comments for now.

Library/Tracking/Koala.swift Outdated Show resolved Hide resolved
Library/Tracking/Koala.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Library/Tracking/Koala.swift Outdated Show resolved Hide resolved
@ifbarrera ifbarrera merged commit c4e6738 into master Dec 17, 2019
@ifbarrera ifbarrera deleted the NT-707-white-listing-cleanup branch December 17, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants