-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-707] Naming changes and white-listing clean events #995
Conversation
…NT-645-discovery-props-rename # Conflicts: # Library/Tracking/KoalaTests.swift
@@ -2127,39 +2135,6 @@ private func projectProperties( | |||
.prefixedKeys(prefix) | |||
} | |||
|
|||
private func properties( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was almost completely redundant with projectProperties
. Any actually unique props were moved up to the actual tracking function.
|
||
self.vm.inputs.viewDidAppear() | ||
|
||
XCTAssertEqual(["Viewed Account"], koalaClient.events) | ||
XCTAssertEqual(["Viewed Account"], dataLakeClient.events) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this test anymore since we're testing white-listing events now.
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - will test it further, had some minor comments for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
📲 What
Updates some of the naming of certain props to reflect latest changes from insights team. Also adds white-listing on "clean" events, so that only white-listed events are sent to the data lake.
🤔 Why
More event cleanup and ensuring that only clean events go to the data lake.
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria
Testing white-listing:
KOALA_TRACKING_ENABLED
is set totrue
, then run the app. On app launch, you should see the eventApp Open
track on the Koala client. You should not see it track on the data lake client.Project Page Viewed
track on both the Koala and Lake clientsTesting discovery props changes:
Explore Page Viewed
event, you should see:discover_category_name
, and it should sayArt
(the parent category)discover_subcategory_name
and it should sayCeramics
(the current category)discover_category_id
anddiscover_subcategory_id
Explore Page Viewed
event should fire with a propertydiscover_pwl: true
Explore Page Viewed
event should fire with a propertydiscover_watched: true