-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-681] CTA button reload fix #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Had one or two suggestions.
NotificationCenter.default | ||
.addObserver( | ||
self, | ||
selector: #selector(self.didBackProject), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace self
with ProjectPamphletViewController
.
self.notifyDelegateShouldDismissAndShowSuccessBannerWithMessage | ||
= self.cancelPledgeDidFinishWithMessageProperty.signal.skipNil() | ||
self.notifyDelegateManagePledgeViewControllerFinishedWithMessage | ||
= Signal.merge( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can fit on the previous line.
@@ -31,7 +31,7 @@ public protocol ThanksViewModelOutputs { | |||
var backedProjectText: Signal<NSAttributedString, Never> { get } | |||
|
|||
/// Emits when view controller should dismiss | |||
var dismissToRootViewController: Signal<(), Never> { get } | |||
var dismissToRootViewController: Signal<Notification, Never> { get } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to dismissToRootViewControllerAndPostNotification
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
📲 What
🤔 Why
🛠 How
projectBacked
that will send a message to the Project Page once the user taps theX
button on the Thanks Page.✅ Acceptance criteria
The CTA button should load when:
The CTA button should not load when:
Creator's bio
,Campaign page
,Comments
andUpdates