Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setupbouquet.py] "setList" before "updateList" #5

Closed
wants to merge 1 commit into from

Conversation

Huevos
Copy link

@Huevos Huevos commented Jun 21, 2021

No description provided.

@Huevos Huevos marked this pull request as draft June 21, 2021 18:39
@kiddac
Copy link
Owner

kiddac commented Jul 4, 2021

The whole point of using updatelist is not to use setlist. So recommending using setlist before updatelist in this function is not the solution to this problem.

def updateList(self, list):
	"""Changes the list without changing the selection or emitting changed Events"""

But there is an error in my code, as I don't actually set the list anywhere on load.

image

@kiddac kiddac closed this Jul 4, 2021
@kiddac
Copy link
Owner

kiddac commented Jul 4, 2021

The problem lies is in your list.py

def getIndex(self):
	return self.master.index if self.master is not None else None

this should actually return 0

In python 3 you cannot perform arithmetic on None.
if self.getIndex() + 1

@Huevos

@Huevos
Copy link
Author

Huevos commented Jul 4, 2021

The problem is how your plugin is using this. No other code has problems with this because it is being used as intended.

https://github.com/OpenPLi/enigma2/blob/develop/lib/python/Screens/Satconfig.py#L317-L318

@Huevos
Copy link
Author

Huevos commented Jul 4, 2021

Only reason this plugin ever worked in Py2 is because asserts are only triggered during debug mode.

@kiddac
Copy link
Owner

kiddac commented Jul 4, 2021

My JediMakerXtream plugin has now been updated and should now be fully functional with openvix new code.

@Huevos
Copy link
Author

Huevos commented Jul 4, 2021

Cool.

If possible, xstremity needs the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants