PlayerInfo functionality #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalpowar
commented
Jun 8, 2014
kunalpowar
commented
- also added a few glogs to enable debugging
| type A2SPlayerRequest struct { | ||
| } | ||
|
|
||
| func (A2SPlayerRequest) MarshalBinaryFromChallenge(c ChallengeResponse) ([]byte) { |
There was a problem hiding this comment.
MarshalBinary is from http://tip.golang.org/pkg/encoding/#BinaryMarshaler
There was a problem hiding this comment.
the A2SPlayerRequest should be instantiated with the ChallengeResponse, and not passed to this method
There was a problem hiding this comment.
Get the marshalBinary part. But Why should A2SPlayerRequest know Challenge Response. It is built using a challenge Response. The request itself need not have the challenge as a separate entity. In fact the first implementation had something like
type A2SPlayerRequest struct {
c ChallengeResponse
}
|
thanks for the PR. we definitely needed this
|
|
Thanks for the feedback. Am still in progress of cleaning up the code. Will solve the issues you pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.