🐛 Fix writing of job logs in local development #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 94.87% 95.01% +0.13%
==========================================
Files 172 172
Lines 7478 7479 +1
==========================================
+ Hits 7095 7106 +11
+ Misses 383 373 -10
Continue to review full report at Codecov.
|
znatty22
force-pushed
the
fix-local-job-logs
branch
from
15e89c5
to
87b0426
Compare
Django raises a SuspiciousFileOperation exception if the API tries to write into the BASE_DIR. We needed to move the local logs directory outside base application directory
znatty22
force-pushed
the
fix-local-job-logs
branch
from
87b0426
to
6ebd02c
Compare
dankolbman
approved these changes
Sep 29, 2021
The path names definitely causes that suspicious exception but I stripped those out and it was still raising the exception. It was only after I removed the BASE_DIR that it worked. |
znatty22
added a commit
that referenced
this pull request
Sep 30, 2021
## Release 1.19.7 ### Summary - Emojis: 🐛 x2, ♻️ x1 - Categories: Fixes x2, Other Changes x1 ### New features and changes - [#768](#768) - 🐛 Fix API logging - [b07e9b9](b07e9b9) by [znatty22](https://github.com/znatty22) - [#767](#767) - 🐛 Fix writing of job logs in local development - [d078b8e](d078b8e) by [znatty22](https://github.com/znatty22) - [#763](#763) - ♻️ Omit Content-Length header in download validation report - [f61c0e8](f61c0e8) by [znatty22](https://github.com/znatty22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #766
Django raises a
SuspiciousFileOperationexception if the API tries to write into the BASE_DIR. We needed to move the local logs directory outside base application directory