Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add sequencing experiment conformance resources #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ Add sequencing experiment conformance resources #198

wants to merge 1 commit into from

Conversation

nicholasvk
Copy link

@nicholasvk nicholasvk commented Sep 14, 2020 •
edited by liberaliscomputing
Loading

This PR adds sequencing experiment example resources. It also closes #190.

@liberaliscomputing liberaliscomputing added feature model Model development labels Sep 14, 2020
@liberaliscomputing liberaliscomputing changed the title ✨ Add se conf resources ✨ Add sequencing center conformance resources Sep 14, 2020
@liberaliscomputing liberaliscomputing changed the title ✨ Add sequencing center conformance resources ✨ Add sequencing experiment conformance resources Sep 14, 2020
@liberaliscomputing liberaliscomputing mentioned this pull request Sep 15, 2020
Open
@liberaliscomputing liberaliscomputing marked this pull request as ready for review September 24, 2020 18:46
fiendish
fiendish reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@fiendish fiendish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Observation here looks like it's describing the GF, not the SE at all. Giving it ID prefix "s" and text "sequencing_experiment" seems inapt.

@nicholasvk
Copy link
Author

nicholasvk commented Oct 14, 2020 •
edited
Loading

The Observation here looks like it's describing the GF, not the SE at all. Giving it ID prefix "s" and text "sequencing_experiment" seems inapt.

It is describing what was observed about a GF as a result of the sequencing experiment. Our thinking was that since this information will only be derived as part of the output of a sequencing experiment, that it made sense to code it the same way to indicate a relationship between this observation and task. I see your point though, and am open to making the change if @liberaliscomputing agrees.

@gsantia gsantia removed their request for review January 18, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiendish fiendish fiendish left review comments

@liberaliscomputing liberaliscomputing liberaliscomputing left review comments

@znatty22 znatty22 Awaiting requested review from znatty22

@ShahimEssaid ShahimEssaid Awaiting requested review from ShahimEssaid

At least 1 approving review is required to merge this pull request.

Assignees

@nicholasvk nicholasvk

@liberaliscomputing liberaliscomputing

@youngnm youngnm

Labels
feature model Model development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop and test Kids First sequencing experiment conformance resources
4 participants
@nicholasvk @fiendish @liberaliscomputing @youngnm