Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kf-portal-ui#821 Remove 2nd tooltip (icon-controlled-access) from pop… #1018

Merged

Conversation

nyanofthemoon
Copy link
Contributor

…ping up after extended hover

@nyanofthemoon nyanofthemoon changed the title WIP: kf-portal-ui#821 Remove 2nd tooltip (icon-controlled-access) from pop… kf-portal-ui#821 Remove 2nd tooltip (icon-controlled-access) from pop… Dec 5, 2018
Copy link
Contributor

@hlminh2000 hlminh2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) just seems like prettier is a bit off?

Copy link
Contributor

@ciaranschutte ciaranschutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@nyanofthemoon
Copy link
Contributor Author

@ciaranschutte @hlminh2000 Cool! Who merges / how can I merge?

Copy link
Contributor

@hlminh2000 hlminh2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciaranschutte you wanna do a deploy? :)

@hlminh2000 hlminh2000 merged commit f17c2a9 into next Dec 7, 2018
@hlminh2000 hlminh2000 deleted the feature/direct-users-to-controlled-access-application branch December 7, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants