cart-item connection sorting patched

kidunot89 · Apr 24, 2019 · c7d5464 · c7d5464
1 parent 48f0110
commit c7d5464
Show file tree

Hide file tree

Showing 7 changed files with 202 additions and 193 deletions.
diff --git a/src/data/connection/class-cart-item-connection-resolver.php b/src/data/connection/class-cart-item-connection-resolver.php
@@ -27,7 +27,16 @@ class Cart_Item_Connection_Resolver {
 	 * @return array
 	 */
 	public function filter( $items, $args = array() ) {
-		return array_values( $items );
+		$filter_items = array_values( $items );
+
+		usort(
+			$filter_items,
+			function( $item_a, $item_b ) {
+				return strcmp( $item_a['key'], $item_b['key'] );
+			}
+		);
+
+		return $filter_items;
 	}
 
 	/**

diff --git a/tests/_support/Helper/Wpunit.php b/tests/_support/Helper/Wpunit.php
@@ -4,75 +4,75 @@
 // here you can define custom actions
 // all public methods declared in helper class will be available in $I
 class Wpunit extends \Codeception\Module {
-    /**
-     * HOOK:
-     * triggered after module is created and configuration is loaded
-     */
-    public function _initialize()
-    {
-        require_once __DIR__ . '/crud-helpers/wcg-helper.php';
-        require_once __DIR__ . '/crud-helpers/customer.php';
-        require_once __DIR__ . '/crud-helpers/coupon.php';
-        require_once __DIR__ . '/crud-helpers/product.php';
-        require_once __DIR__ . '/crud-helpers/product-variation.php';
-        require_once __DIR__ . '/crud-helpers/shipping-method.php';
-        require_once __DIR__ . '/crud-helpers/tax-rate.php';
-        require_once __DIR__ . '/crud-helpers/order-item.php';
-        require_once __DIR__ . '/crud-helpers/order.php';
-        require_once __DIR__ . '/crud-helpers/refund.php';
-        require_once __DIR__ . '/crud-helpers/cart.php';
-    }
+	/**
+	 * HOOK:
+	 * triggered after module is created and configuration is loaded
+	 */
+	public function _initialize()
+	{
+		require_once __DIR__ . '/crud-helpers/wcg-helper.php';
+		require_once __DIR__ . '/crud-helpers/customer.php';
+		require_once __DIR__ . '/crud-helpers/coupon.php';
+		require_once __DIR__ . '/crud-helpers/product.php';
+		require_once __DIR__ . '/crud-helpers/product-variation.php';
+		require_once __DIR__ . '/crud-helpers/shipping-method.php';
+		require_once __DIR__ . '/crud-helpers/tax-rate.php';
+		require_once __DIR__ . '/crud-helpers/order-item.php';
+		require_once __DIR__ . '/crud-helpers/order.php';
+		require_once __DIR__ . '/crud-helpers/refund.php';
+		require_once __DIR__ . '/crud-helpers/cart.php';
+	}
 
-    public function cart() {
-        return \CartHelper::instance();
-    }
+	public function cart() {
+		return \CartHelper::instance();
+	}
 
-    public function coupon() {
-        return \CouponHelper::instance();
-    }
+	public function coupon() {
+		return \CouponHelper::instance();
+	}
 
-    public function customer() {
-        return \CustomerHelper::instance();
-    }
+	public function customer() {
+		return \CustomerHelper::instance();
+	}
 
-    public function order() {
-        return \OrderHelper::instance();
-    }
+	public function order() {
+		return \OrderHelper::instance();
+	}
 
-    public function item() {
-        return \OrderItemHelper::instance();
-    }
+	public function item() {
+		return \OrderItemHelper::instance();
+	}
 
-    public function product() {
-        return \ProductHelper::instance();
-    }
+	public function product() {
+		return \ProductHelper::instance();
+	}
 
-    public function product_variation() {
-        return \ProductVariationHelper::instance();
-    }
+	public function product_variation() {
+		return \ProductVariationHelper::instance();
+	}
 
-    public function refund() {
-        return \RefundHelper::instance();
-    }
+	public function refund() {
+		return \RefundHelper::instance();
+	}
 
-    public function shipping_method() {
-        return \ShippingMethodHelper::instance();
-    }
+	public function shipping_method() {
+		return \ShippingMethodHelper::instance();
+	}
 
-    public function tax_rate() {
-        return \TaxRateHelper::instance();
-    }
+	public function tax_rate() {
+		return \TaxRateHelper::instance();
+	}
 
-    public function get_nodes( $ids, $crud ) {
-        $nodes = array();
+	public function get_nodes( $ids, $crud ) {
+		$nodes = array();
 		foreach( $ids as $id ) {
 			$nodes[] = $crud->get_query_data( $id );
 		}
 
 		return array( 'nodes' => $nodes );
 	}
 
-    public function clear_loader_cache( $loader_name ) {
+	public function clear_loader_cache( $loader_name ) {
 		$loader = \WPGraphQL::get_app_context()->getLoader( $loader_name );
 		$loader->clearAll();
 	}

diff --git a/tests/_support/Helper/crud-helpers/cart.php b/tests/_support/Helper/crud-helpers/cart.php
@@ -53,7 +53,7 @@ public function print_nodes( $processors = array() ) {
 				return array( 'key' => $key ); 
 			},
 			'sorter' => function( $key_a, $key_b ) {
-				return 0;
+				return strcmp( $key_a, $key_b );
 			},
 			'filter' => function( $key ) {
 				return true;