Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2813: java.io.IOException: Too many open files using business-central #1108

Merged
merged 1 commit into from Apr 14, 2021

Conversation

akumar074
Copy link
Member

  • Deleting all branches index when deleting a project

JIRA:
RHPAM-3309
AF-2813

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@akumar074
Copy link
Member Author

Jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

@akumar074
Copy link
Member Author

Jenkins run cdb

@barboras7
Copy link
Contributor

jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

akumar074 commented Mar 1, 2021

FDB test failure is unrelated

@barboras7
Copy link
Contributor

Hi @akumar074,
it seems that I have issues with indexing of assets after re-importing of project. Steps to reproduce:

  1. Import Mortgage_Process project
  2. Delete the project
  3. Import the project again
    RESULT:
    Screenshot from 2021-03-02 11-13-00

This happens sometimes after first reimport, sometimes after another one, but it seems to be reproducible. Could you please check this?

@barboras7
Copy link
Contributor

@akumar074 any updates on this? Today is the freeze for 7.10.1 CR1

@akumar074
Copy link
Member Author

@akumar074 any updates on this? Today is the freeze for 7.10.1 CR1

Hi @barboras7 I am looking into this, but having a problem debugging. If not possible, we'll have to push it for a later release.

@akumar074
Copy link
Member Author

Jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins retest this

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins retest this

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

@barboras7
Copy link
Contributor

Hi @akumar074,
thanks for the provided .war file. I checked and the issue that I mentioned above is already fixed.

To check the number of open files in the business central, I used lsof -p jps|grep 'jboss-modules'|cut -d ' ' -f 1|grep -c '<pathToFolderWhereBusinessCentralIsLaunched>/.index'.

I tried it multiple times, following are the numbers returned by the lsof command (I used Mortgage_Process project):
9 (before the first import), 25 (after the first import), 25 (first delete), 25 (second import), 25 (second delete), 72 (third import), 40 (third delete), 35, 35, 25, 25, 40, 40, 53, 53, 105, 25, 83, 83, 83.
Are these numbers acceptable? I am not sure if after each delete, we should get to the same number or it's fine that the numbers are increasing a bit.

@akumar074
Copy link
Member Author

Hi @barboras7 ,

As I mentioned on the JIRA ticket when you delete a project it is marked as deleted and it is actually deleted after sometime within a minute. Till then the indexes are kept in the .index. After the deletion is done, we have some files deleted but opened in JVM. These files will get cleared after the GC cleans.
To confirm this you can use jvisualVM to clean the GC. you will see the reduced number of opened files then.

@akumar074
Copy link
Member Author

jenkins run fdb

@barboras7
Copy link
Contributor

Hi @akumar074,
I am sorry, I did not notice the comment. I tried and the files are getting deleted correctly. Thank you.

@adrielparedes
Copy link
Contributor

jenkins run fdb

2 similar comments
@akumar074
Copy link
Member Author

jenkins run fdb

@akumar074
Copy link
Member Author

jenkins run fdb

@akumar074
Copy link
Member Author

jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

jenkins run fdb

 * Deleting all branches index when deleting a project
@akumar074
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adrielparedes
Copy link
Contributor

@akumar074 the FDB error is related to your changes?

@akumar074
Copy link
Member Author

@adrielparedes the failing test isn't related to changes.

import java.util.concurrent.ConcurrentHashMap;

@RunWith(MockitoJUnitRunner.class)
public class LuceneInedexManagerTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akumar074 do the rename just for master

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor rename

@ederign ederign merged commit 8553bd1 into kiegroup:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants