New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHPAM-3845 : Imported projects not visible after migration from RHPAM 6.4 to 7.11 #1190
Conversation
|
||
//Only load and cache if a file was found! | ||
final Iterator<Path> it = foundConfigs.iterator(); | ||
if (it.hasNext()) { | ||
while (it.hasNext()) { | ||
final String content = ioService.readAllString(it.next()); | ||
final ConfigGroup configGroup = marshaller.unmarshall(content); | ||
if (namespace != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, what happens is there is no namespace (or it is null)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrielparedes ideally it should fetch the namespace from the repository config file, as a result of unmarshalling on line 307. But we found that in some versions, config file didn't contain the namespace. so if the namespace is null on line 308, this means either the namespace is fetched from the file or the resource doesn't require a namespace at all (like spaces).
Kudos, SonarCloud Quality Gate passed! |
Jenkins run fdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested locally. Looks good to me. 🙂
@RishiRajAnand is there any problem with tests? |
@adrielparedes the error is org.uberfire.ext.metadata.backend.infinispan.provider.InfinispanPingServiceTest.testPingSuccess this error can be seen in multiple unrelated PR's. |
Thank you for submitting this pull request
RHPAM-3462: https://issues.redhat.com/browse/RHPAM-3462
RHPAM-3845: https://issues.redhat.com/browse/RHPAM-3845
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream