Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-2933 : Business Cental fails to start with error "no marshaller for type: org.guvnor.structure.contributors.Contributor" after migrating to 7.12.0 #1237

Merged
merged 2 commits into from Mar 4, 2022
Merged

AF-2933 : Business Cental fails to start with error "no marshaller for type: org.guvnor.structure.contributors.Contributor" after migrating to 7.12.0 #1237

merged 2 commits into from Mar 4, 2022

Conversation

akumar074
Copy link
Member

  • Fixing Contributor and ContributorType packages

JIRA:

AF-2933
RHPAM-4152

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@akumar074
Copy link
Member Author

Jenkins run fdb

@sthundat sthundat self-requested a review February 17, 2022 13:10
@akumar074
Copy link
Member Author

Jenkins run fdb

@sthundat
Copy link

sthundat commented Feb 22, 2022 •
edited

@akumar074
Hi Abhishek,

Thanks for the PR!

PR has fixed the Marshaling error and spaces/projects are successfully migrated to the new version(7.12.0) of BC using migration tool.

But I have observed below repository not found error with dashbuilder while starting business central with the migrated version.

12:11:39,376 ERROR [org.uberfire.ext.metadata.io.BatchIndex] (Thread-114) Index fails. [@dashbuilder/datasets/master]: java.util.concurrent.CompletionException: java.lang.RuntimeException: Repository not found inside space dashbuilder with path default://master@dashbuilder/datasets/definitions/gitContributors.dset (root path default://master@dashbuilder/datasets/) at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1705) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829)
While migrating I have used one sample pom-migration.json file for pom migration with some repository details that I get it from the documentation.
Link for the documentation,
https://access.redhat.com/documentation/en-us/red_hat_process_automation_manager/7.4/html/patching_and_upgrading_red_hat_process_automation_manager_7.4/migration-tool-niogit-7.4-proc_patching-upgrading

2.Can you please add relevant tests for this issue?

Please let me know your inputs.

Thanks,
Savitha

sthundat
sthundat reviewed Feb 22, 2022
View reviewed changes
...main/java/org/guvnor/structure/backend/organizationalunit/config/SpaceConfigStorageImpl.java Outdated
return objectStorage.read(path);
}
} catch (Exception e) {
throw new RuntimeException(e);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to pass message while creating the runtime exception

...main/java/org/guvnor/structure/backend/organizationalunit/config/SpaceConfigStorageImpl.java Outdated
logger.error(e.getMessage());
return fixContributorClassInSpaceInfo();
}
throw new RuntimeException(e);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to pass an exception message string while creating the runtime exception

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, also we are not loggin the problem unless it is a MarshallingException problem.

@akumar074
Copy link
Member Author

Jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

Jenkins run fdb

@sthundat
Copy link

@akumar074
Hi Abhishek,
I observed that, the error I have mentioned above happening only when I first time starts the BC after migration.But it doesn't break any functionality of BC.Hence I would suggest we can close this issue and I can create a separate Jira to track the above issue.
WDYT?
thanks,
Savitha

@akumar074
Copy link
Member Author

Hi @sthundat
I agree we can create a new Jira to track the above error. I'll add some tests for this and we can resolve this issue.
Thanks

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

1 similar comment
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
AF-2933 : Business Central fails to start with error "no marshaller f…
14fa284 
…or type: org.guvnor.structure.contributors.Contributor" after migrating to 7.12.0

 - Fixing Contributor and ContributorType packages
@akumar074
Copy link
Member Author

Jenkins run fdb

1 similar comment
@sthundat
Copy link

sthundat commented Mar 2, 2022

Jenkins run fdb

@akumar074
AF-2933 : Business Central fails to start with error "no marshaller f…
85e20c8 
…or type: org.guvnor.structure.contributors.Contributor" after migrating to 7.12.0

 - Fixing Contributor and ContributorType packages
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Hi @sthundat @adrielparedes @RishiRajAnand I have made changes according to the comments. Please rereview the PR when you can.
Thanks

@akumar074
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@sthundat
Copy link

sthundat commented Mar 3, 2022

Hi @akumar074 ,
Thanks for the changes.
FDB doesn't generate the migration tool.
Can you built migration tool for the final check
thanks,
Savitha

@akumar074
Copy link
Member Author

@sthundat I will build the migration tool locally and share the zip with you

@akumar074
Copy link
Member Author

Add-ons Zip for migration tool: https://drive.google.com/file/d/1DJpna3Tzw9u1ZWLWfz4hPkuS5_CNSr0e/view?usp=sharing

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run cdb

@sthundat
Copy link

sthundat commented Mar 4, 2022

@akumar074
Hi Abhishek,
Changes looks good to me.Created Jira for repository not found exceptionLink
Thanks,
Savitha

@akumar074
Copy link
Member Author

Hi @adrielparedes , We have all the approvals required with Green FDB build. Can we go ahead and merge this?
Thanks

@akumar074
Copy link
Member Author

Jenkins run cdb

@mareknovotny mareknovotny merged commit dd9f0ba into kiegroup:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrielparedes adrielparedes adrielparedes approved these changes

@RishiRajAnand RishiRajAnand RishiRajAnand approved these changes

@sthundat sthundat sthundat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@akumar074 @sthundat @adrielparedes @RishiRajAnand @mareknovotny