Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-7558 : SSH clone: Fetch roles for the logged in user from the realm itself #1404

Merged
merged 1 commit into from Dec 8, 2023

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented Sep 20, 2023

JIRA:

DROOLS-7558

WorkbenchUserManager depends on the Elytron file system realm and for that reason can not find or log in the user.

war

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@Rikkola
Copy link
Member Author

Rikkola commented Sep 20, 2023

Jenkins run fdb

@Rikkola Rikkola changed the title Fix without tests DROOLS-7558 : SSH clone: Fetch roles for the logged in user from the realm itself Sep 20, 2023
@Rikkola
Copy link
Member Author

Rikkola commented Sep 20, 2023

Jenkins run fdb

@Rikkola
Copy link
Member Author

Rikkola commented Sep 21, 2023

@Rikkola
Copy link
Member Author

Rikkola commented Sep 22, 2023

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@Rikkola
Copy link
Member Author

Rikkola commented Sep 25, 2023

@Rikkola
Copy link
Member Author

Rikkola commented Sep 26, 2023

@domhanak This should work. I uploaded and linked a war.

@mareknovotny
Copy link
Member

was this already reviewed? @domhanak just curious

@tomasdavidorg tomasdavidorg requested review from tomasdavidorg and removed request for domhanak December 6, 2023 13:30
@tomasdavidorg
Copy link
Contributor

@mareknovotny I will take a look.

Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks 🙂

@mareknovotny mareknovotny added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Dec 8, 2023
@mareknovotny mareknovotny merged commit c463ad5 into kiegroup:main Dec 8, 2023
8 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
mareknovotny pushed a commit that referenced this pull request Dec 12, 2023
…realm itself (#1404) (#1407)

Co-authored-by: Toni Rikkola <toni@rikkola.net>
mareknovotny pushed a commit that referenced this pull request Dec 12, 2023
…realm itself (#1404) (#1408)

Co-authored-by: Toni Rikkola <toni@rikkola.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
3 participants