[AF-1102] Git repos disappearing when you clone a repo twice with a invalid remote in the second try

[ederign]

No description provided.

[jhrcek]

Jenkins execute full downstream build

[porcelli]

good catch @ederign and @jhrcek - this issue happened since ever, thx for spot this issue.

[jhrcek]

@ederign I tested this locally and I'm no longer able to reproduce this issue. Thanks for this quick fix!
I just have an optional nitpick about expected exception testing..

[jhrcek]

Nitpick: you can use

assertThatThrownBy( () -> /* some code that throws exception*/)
   .isInstanceOf(Clone.CloneException.class)
   .hasMessage("specific message"); //or hasMessageContaining("substring");

to only wrap the statement which is supposed to throw exception. This would not only give more useful error message in case that assertion fails, but also makes the test more informative (what kind of failure are we expecting and which statement is supposed to throw it?) and focused (it would fail if the same exception is accidentally thrown by some other statement in the test).

[ederign]

@jhrcek thanks for the hint and the detailed reproducer.