Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AF-1401] Some user actions don't fire post-commit hook: create data object, modify data object #418

Merged
merged 1 commit into from Jul 17, 2018

Conversation

ederign
Copy link
Member

@ederign ederign commented Jul 16, 2018

Tomas and Porcelli.

The post-commit hook was not called in VFS batch mode. This is fixed by this PR.

This doesn't fix the 'create project hook' because there is no hook for 'creating project'. But we do some commits in the project creation, so probably user can track those on this case.

Tomas, in order to test it:

a1 is the project name.

➜ /tmp cd fs-drools-wb/.niogit/a1/a1.git
➜ a1.git git:(master) ls
HEAD branches config db.lock hooks logs objects refs
➜ a1.git git:(master) cd hooks
➜ hooks git:(master) ls
post-commit
➜ hooks git:(master) cat post-commit
date >> /tmp/hookCalledg

To place the hooks automatically on new repos:

-Dorg.uberfire.nio.git.hooks=/tmp/hooks

But only do this with all the system repos already created. You don't want to have hooks on those. :-)

Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ederign. I built the war locally and I checked that post-commit hook works.

@ederign ederign merged commit 5d491c9 into kiegroup:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants