Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROOLS-5264: Clear selected file when dialog is closed #949

Merged
merged 1 commit into from May 28, 2020
Merged

DROOLS-5264: Clear selected file when dialog is closed #949

merged 1 commit into from May 28, 2020

Conversation

jomarko
Copy link

@jomarko jomarko commented Apr 22, 2020

This PR clear the last selected file from file selector widget when the dialog for artifact upload is closed or canceled.

For more details see: https://issues.redhat.com/browse/DROOLS-5264

@jomarko
Copy link
Author

jomarko commented Apr 22, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Apr 23, 2020

Failed tests

org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.testWorkingSetGlobalTestSessionSetAndGetGlobal
org.kie.camel.embedded.camel.component.JSonBatchExecutionTest.testManualFireAllRules
org.kie.camel.embedded.camel.component.JSonBatchExecutionTest.testInsertElements
org.kie.camel.embedded.camel.component.JSonBatchExecutionTest.testInsertElementsWithReturnObjects
org.kie.camel.embedded.camel.component.XStreamBatchExecutionTest.testInsertElementsWithReturnObjects

@jomarko
Copy link
Author

jomarko commented Apr 23, 2020

jenkins execute full downstream build

@ederign ederign requested a review from caponetto April 23, 2020 17:33
caponetto
caponetto approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jomarko
Copy link
Author

jomarko commented Apr 23, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Apr 27, 2020

jenkins execute full downstream build

2 similar comments
@jomarko
Copy link
Author

jomarko commented May 11, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 12, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 13, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 14, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 15, 2020

jenkins please retest this

@jomarko
Copy link
Author

jomarko commented May 15, 2020

jenkins execute full downstream build

1 similar comment
@jomarko
Copy link
Author

jomarko commented May 17, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 18, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 18, 2020

jenkins please retest this

@mbiarnes
Copy link
Contributor

Jenkins retest this please

@jomarko
Copy link
Author

jomarko commented May 18, 2020

jenkins execute full downstream build

2 similar comments
@jomarko
Copy link
Author

jomarko commented May 18, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 19, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 20, 2020

Failed test:

org.jbpm.test.functional.async.AsyncMultisubprocessTest.testCorrectProcessStateAfterExceptionEndSignal

@jomarko
Copy link
Author

jomarko commented May 20, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 21, 2020

Failures in master downstream

  • OOME

Failures in mbiarnes downstream

org.kie.hacep.SnapshotOnDemandTest.createSnapshotOnDemandTest
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.hacep.core.infra.utils.ConsumerUtilsCoreTest.lastEventWithoutKafkaUpTest
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceSubProcess
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testPersistenceVariables
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testTransactionsRollback
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcessWithListeners
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcess

@jomarko
Copy link
Author

jomarko commented May 21, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented May 22, 2020

Failed tests mbiarnes custom job:

org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.hacep.core.infra.utils.ConsumerUtilsCoreTest.lastEventWithoutKafkaUpTest
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceSubProcess
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testPersistenceVariables
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testTransactionsRollback
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcessWithListeners
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcess

master job

  • org.kie.bc.DeploymentIT.org.kie.bc.DeploymentIT

@jomarko
Copy link
Author

jomarko commented May 22, 2020

jenkins execute full downstream build

1 similar comment
@jomarko
Copy link
Author

jomarko commented May 25, 2020

jenkins execute full downstream build

@mareknovotny
Copy link
Member

@jomarko please rebase as these enforcer errors were fixed already
you should see in the ignores wildfly-elytron dependency

@jomarko
Copy link
Author

jomarko commented May 25, 2020

@mareknovotny thank you for notice, I rebased and force pushed my branch.

@jomarko
Copy link
Author

jomarko commented May 25, 2020

jenkins execute full downstream build

DROOLS-5264: Clear selected file when dialog is closed
7838385 
This PR clear the last selected file from file selector widget when the dialog for artifact upload is closed or canceled.

For more details see: https://issues.redhat.com/browse/DROOLS-5264
@jomarko
Copy link
Author

jomarko commented May 27, 2020

jenkins execute full downstream build

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@jomarko
Copy link
Author

jomarko commented May 28, 2020

@kiegroup/gatekeepers please merge.

@danielezonca danielezonca merged commit ce4de87 into kiegroup:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caponetto caponetto caponetto approved these changes

@Srihari1192 Srihari1192 Srihari1192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@jomarko @mbiarnes @mareknovotny @caponetto @Srihari1192 @danielezonca