Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-3432 : While using the same template key with difference objects/attributes causes an exception when switching to the Data tab in a Guided Rule Template #1134

Merged
merged 1 commit into from May 29, 2019

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented May 7, 2019

https://issues.jboss.org/browse/DROOLS-3432
If the same variable is used for two fields the UI defaults to String cell editor.

PRs:
https://github.com/kiegroup/drools/pull/2332
#1134

@@ -63,6 +64,10 @@ public TemplateDataCellFactory(AsyncPackageDataModelOracle oracle,
*/
public DecoratedGridCellValueAdaptor<? extends Comparable<?>> getCell(TemplateDataColumn column) {

if(column.getDataType().equals(TemplateModel.DEFAULT_TYPE)){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you need to do something similar for the Guided Decision Table's use of "BRL Fragments".

I had a quick look around for where a similar change is needed, but unfortunately my brain let me down.

I'd put a break point in BRLConditionVariableColumnConverter and see where it leads.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, good thing you spotted this. I'll look for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BRLConditionColumnPlugin.getDefinedVariables(RuleModel ruleModel) is where I need to add some changes. Adding this here as a reminder for myself ;)

@manstis manstis requested a review from jomarko May 9, 2019 09:52
@jomarko
Copy link

jomarko commented May 10, 2019

No comment to code, manual check pending.

@jomarko
Copy link

jomarko commented May 13, 2019

Screenshot from 2019-05-13 09-53-43

@manstis was right, guided decision tables need an update too.

…ts/attributes causes an exception when switching to the Data tab in a Guided Rule Template
@Rikkola
Copy link
Member Author

Rikkola commented May 23, 2019

@jomarko @manstis These PRs could use a rereview thank you.

Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Rikkola

@Rikkola
Copy link
Member Author

Rikkola commented May 29, 2019

@manstis this needs to go in too :)

@manstis manstis merged commit 8b1d515 into kiegroup:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants