New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROOLS-3432 : While using the same template key with difference objects/attributes causes an exception when switching to the Data tab in a Guided Rule Template #1134
Conversation
@@ -63,6 +64,10 @@ public TemplateDataCellFactory(AsyncPackageDataModelOracle oracle, | |||
*/ | |||
public DecoratedGridCellValueAdaptor<? extends Comparable<?>> getCell(TemplateDataColumn column) { | |||
|
|||
if(column.getDataType().equals(TemplateModel.DEFAULT_TYPE)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately you need to do something similar for the Guided Decision Table's use of "BRL Fragments".
I had a quick look around for where a similar change is needed, but unfortunately my brain let me down.
I'd put a break point in BRLConditionVariableColumnConverter
and see where it leads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, good thing you spotted this. I'll look for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRLConditionColumnPlugin.getDefinedVariables(RuleModel ruleModel) is where I need to add some changes. Adding this here as a reminder for myself ;)
No comment to code, manual check pending. |
@manstis was right, guided decision tables need an update too. |
…ts/attributes causes an exception when switching to the Data tab in a Guided Rule Template
8a55384
to
22ca04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rikkola
@manstis this needs to go in too :) |
https://issues.jboss.org/browse/DROOLS-3432
If the same variable is used for two fields the UI defaults to String cell editor.
PRs:
https://github.com/kiegroup/drools/pull/2332
#1134