Drools 4648 Define and Implement a DataModel to hold Background Table Data #1254

gitgabrio · 2019-10-28T14:02:31Z

Client-side part of multi-repo ticket:

https://issues.jboss.org/browse/DROOLS-4648

see https://github.com/kiegroup/drools/pull/2630

This PR implement a specific Background object inside the data model; that object is completely isolated from Simulation and is managed inside the Background grid.
There is only one single history, where modification of both models are stored/managed.
On undo/redo command, currently the tab are not switched (to be implemented in next ticket).

# Conflicts: # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-businesscentral-client/src/main/java/org/drools/workbench/screens/scenariosimulation/businesscentral/client/editor/ScenarioSimulationEditorBusinessCentralWrapper.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/commands/ScenarioSimulationContext.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/commands/actualcommands/AbstractScenarioSimulationCommand.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/commands/actualcommands/AbstractSelectedColumnCommand.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenter.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorWrapper.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationView.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationViewImpl.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/strategies/AbstractDMNDataManagementStrategy.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/factories/CollectionEditorSingletonDOMElementFactory.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/test/java/org/drools/workbench/screens/scenariosimulation/client/commands/actualcommands/AbstractScenarioSimulationCommandTest.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/test/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenterTest.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/test/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationViewImplTest.java

# Conflicts: # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-backend/src/main/java/org/drools/workbench/screens/scenariosimulation/backend/server/util/DMNSimulationSettingsCreationStrategy.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/main/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenter.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-client/src/test/java/org/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenterTest.java

gitgabrio · 2019-10-28T18:26:44Z

jenkins please retest this

danielezonca · 2019-10-28T17:45:49Z

...creens/scenariosimulation/client/commands/actualcommands/ScenarioGridWidgetFocusCommand.java

+/**
+ * <code>Command</code> to <b>append</b> (i.e. put in the last position) a row
+ */
+public class ScenarioGridWidgetFocusCommand extends AbstractScenarioSimulationCommand {


Not part of this PR

danielezonca · 2019-10-28T17:47:28Z

...ools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorWrapper.java

+    int SIMULATION_TAB_INDEX = 0;
+    int BACKGROUND_TAB_INDEX = 1;


Why are these value here? What about move them to constantHolder or similar?

@danielezonca
Those value are meaningful only for the ScenarioSimulationEditorWrappers, that's why I put them here

danielezonca · 2019-10-28T17:48:19Z

...ools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorWrapper.java

+    void selectSimulationTab();
+
+    void selectBackgroundTab();


Not part of this PR?

danielezonca · 2019-10-28T17:50:07Z

...rg/drools/workbench/screens/scenariosimulation/client/editor/ScenarioSimulationViewImpl.java

+
+

Well done! 👍
😄

I think one new line would be enough. Ideally no change here. Keep in mind more changes you do in commit == more conflicts resolution in future.

danielezonca · 2019-10-28T17:52:23Z

...n/java/org/drools/workbench/screens/scenariosimulation/client/widgets/ScenarioGridLayer.java

@@ -48,7 +48,7 @@ public ScenarioGrid getScenarioGrid() {
     * @param scenarioGrid ScenarioGrid to add to the Layer
     * @return The Layer
     */
-    public Layer addScenarioGrid(final ScenarioGrid scenarioGrid) {
+    public Layer addScesimDataGrid(final ScenarioGrid scenarioGrid) {


Wrong rename

danielezonca · 2019-10-29T09:19:19Z

...drools/workbench/screens/scenariosimulation/client/commands/ScenarioCommandRegistryTest.java

+    // to restore when implement tab switching
+//    @Test
+//    public void redoNotEmptyDifferentGrid() {
+//        scenarioCommandRegistry.undoneCommands.push(appendRowCommandMock);
+//        when(appendRowCommandMock.commonUndoRedoPreexecution(eq(scenarioSimulationContextLocal))).thenReturn(Optional.of(CommandResultBuilder.SUCCESS));
+//        int currentSize = scenarioCommandRegistry.undoneCommands.size();
+//        scenarioCommandRegistry.redo(scenarioSimulationContextLocal);
+//        assertEquals(currentSize, scenarioCommandRegistry.undoneCommands.size());
+//        verify(scenarioCommandRegistry, never()).commonUndoRedoOperation(eq(scenarioSimulationContextLocal), eq(appendRowCommandMock), eq(false));
+//        verify(scenarioCommandRegistry, never()).setUndoRedoButtonStatus(eq(scenarioSimulationContextLocal));
+//    }


Not part of this PR

danielezonca · 2019-10-29T09:20:42Z

...orkbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenterTest.java

+//    @Test
+//    public void setFocusedContext() {
+//        presenter.setFocusedContext(contextMock);
+//        verify(presenter, times(1)).populateRightDocks(eq(TestToolsPresenter.IDENTIFIER));
+//    }


Commented code

danielezonca · 2019-10-29T09:21:14Z

...orkbench/screens/scenariosimulation/client/editor/ScenarioSimulationEditorPresenterTest.java

+        // TODO {gcardosi} restore after correction on presenter
+//        verify(scenarioBackgroundGridWidgetMock, times(1)).setContent(isA(Simulation.class), eq(scenarioSimulationContextLocal.getSettings().getType()));


? not part of this PR?

danielezonca · 2019-10-29T09:23:03Z

...orkbench/screens/scenariosimulation/client/producers/ScenarioSimulationViewProducerTest.java

-import static org.mockito.Mockito.when;
-
-@RunWith(LienzoMockitoTestRunner.class)
+//@RunWith(LienzoMockitoTestRunner.class)
 public class ScenarioSimulationViewProducerTest extends AbstractProducerTest {


To be removed?

@danielezonca
done

danielezonca · 2019-10-29T09:23:49Z

...st/java/org/drools/workbench/screens/scenariosimulation/client/widgets/ScenarioGridTest.java

@@ -435,13 +436,13 @@ public void testShowContextMenuGivenOrExpect() {
    private Simulation getSimulation() {
        Simulation toReturn = new Simulation();
        SimulationDescriptor simulationDescriptor = toReturn.getSimulationDescriptor();
-        simulationDescriptor.setType(ScenarioSimulationModel.Type.RULE);
+//        simulationDescriptor.setType(ScenarioSimulationModel.Type.RULE);


Commented code

dupliaka · 2019-10-29T10:58:51Z

jenkins execute full downstream build

dupliaka · 2019-10-29T11:18:53Z

...va/org/drools/workbench/screens/scenariosimulation/backend/server/DMNScenarioValidation.java

@@ -56,9 +57,9 @@
     * @return


Add @param settings

@dupliaka
done

dupliaka · 2019-10-29T11:41:33Z

...a/org/drools/workbench/screens/scenariosimulation/backend/server/RULEScenarioValidation.java

     * @param kieContainer
     * @return
     */
    @Override
-    public List<FactMappingValidationError> validate(Simulation simulation, KieContainer kieContainer) {
+    public List<FactMappingValidationError> validate(Simulation simulation, Settings settings, KieContainer kieContainer) {


I noticed you added settings parameter but do not use it. But if we will set rule group for test scenario background would the rule group validated on this step? Shouldn't we include the validation of settings here?

@dupliaka
As far as I remember there was not the validation of any "setting": we could add one, but I'm not sure what/how we would validate; anyway, I would do that in another ticket.
Beside that, that "Settings" param is there only to fullfill the contract of the declared abstract method

gitgabrio · 2019-10-29T16:45:48Z

@danielezonca @dupliaka @yesamer
Ready for re-evaluation

gitgabrio · 2019-10-29T16:46:08Z

jenkins please retest this

danielezonca

LGTM 👍

dupliaka · 2019-10-30T12:13:38Z

...rools/workbench/screens/scenariosimulation/backend/server/ScenarioSimulationServiceImpl.java

@@ -86,62 +87,44 @@
        extends KieService<ScenarioSimulationModelContent>
        implements ScenarioSimulationService {

+    private static final String KIE_VERSION = "kie.version";
+    private static final String junitActivatorPackageName = "testscenario";


Can you tell if you reject to keep the same style on purpose? Shouldn't we change junitActivatorPackageName on JUNIT_ACTIVATOR_PACKAGE_NAME

dupliaka · 2019-10-30T13:01:55Z

...ools/workbench/screens/scenariosimulation/backend/server/util/ScenarioSimulationBuilder.java

+            case DMN:
+                return dmnSimulationCreationStrategy.createBackground(context, value);
+            default:
+                return null;


Question: can we throw an exception here? Like IlligalStateException? So to have a chance to understand what happened by logs in runtime?

dupliaka · 2019-10-30T13:11:59Z

...bench/screens/scenariosimulation/backend/server/util/SimulationSettingsCreationStrategy.java

    }

    /**
     * Create an empty column using factMappingType defined. The new column will be added as last column of
     * the group (GIVEN/EXPECT) (see findLastIndexOfGroup)
     * @param simulationDescriptor
-     * @param scenarioWithIndex
+     * @param scesimDataWithIndex
     * @param placeholderId
     * @param factMappingType


shouldn't we add @param columnIndex

@dupliaka
done

gitgabrio · 2019-11-04T13:59:00Z

Manual review 01

Question, on background tab, bound instances from main tab are listed, is it expected?

@jomarko
How did you create this situation?

gitgabrio · 2019-11-04T14:03:02Z

Manual review 02

Please follow this scenario

Import sample mortgages project

Crate new a.scesim file, just bound given column to Applicant.age and put value to first data row 60

Save and export a.scesim

Result of export can be found in jira

Close a.scesim

Create new b.scesim

Import the attached csv file

Nothing will happen

@jomarko
The imported csv must "conform" to the grid structure is imported in. So, if you export data from a grid with two specifically mapped columns, and then try to import that same csv in another new -empty - grid, nothing will be imported, because the csv is referring to a specific grid configuration. Does this make sense?

gitgabrio · 2019-11-04T14:06:26Z

Manual review 03

user can not bind instance on background tab see the video

What I see in the video is expected - Background grid has different goal and semantics from scenario one. Maybe it should be somehow better enforced

gitgabrio · 2019-11-04T14:18:13Z

Manual review 04

No error popup about current vs actual value for dmn based scenarios
used dmn and scesim

Actually I see the popup

gitgabrio · 2019-11-04T14:20:04Z

Manual Review 05

For DMN based scenarios, expect columns are present in background tab, is it expected?

@jomarko
Fixed

gitgabrio · 2019-11-04T14:24:24Z

If this PR is just about storing the values on Background tab with no real effect to the scenario run, I am done with manual review @gitgabrio could you please confirm and have a look on my comments, here is a summary of jiras related to DROOLS-4648 I reported till now. If some comments need a separate ticket I am fine with that.

https://issues.jboss.org/browse/DROOLS-4720

https://issues.jboss.org/browse/DROOLS-4721

https://issues.jboss.org/browse/DROOLS-4722

https://issues.jboss.org/browse/DROOLS-4723

Thank you for the PR

@jomarko
Thanks, for the moment being Background data are ignored - they are just saved (and restored) from the scesim data, but not used anyway. Not even imported/exported, currently. I have to be sure they are correcltly added/removed/updated/stored/retrieved to the background grid. History should also work for them (keep in mind there is a single history containing both scenario and background modifications)

gitgabrio · 2019-11-04T14:34:02Z

Manual review 01

Question, on background tab, bound instances from main tab are listed, is it expected?

@jomarko
Fixed

gitgabrio · 2019-11-04T14:44:50Z

Manual review 7
Background initialised with properties for DMN based test scenario

@dupliaka
Fixed (duplicate of #1254 (comment) ?)

dupliaka · 2019-11-04T14:52:19Z

Manual review 7
Background initialised with properties for DMN based test scenario

@dupliaka
Fixed (duplicate of #1254 (comment) ?)

I am not sure, My idea was that exactly for DMN we are showing all the properties that we got for DMN in Model, but Background even for DMN should initialise as empty table. Will retest it

gitgabrio · 2019-11-04T14:53:11Z

Manual review 6

Export of simple test scenario is not working:
Values from export file were not shown

"#",Scenario description,GIVEN,EXPECT "#",Scenario description,Driver,Driver "#",Scenario description,age,status 1,TEst scenario 1,12,young 2,TEst scenario 1,12,young 3,TEst scenario 1,12,young

Error "A CSV file with an incorrect header layout has been imported. Make sure the imported CSV file has unmodified headers."

@dupliaka See #1254 (comment) - it works if the newly created target grid has the same columns as the original one

dupliaka · 2019-11-04T14:57:32Z

Manual review 6
Export of simple test scenario is not working:
Values from export file were not shown
"#",Scenario description,GIVEN,EXPECT "#",Scenario description,Driver,Driver "#",Scenario description,age,status 1,TEst scenario 1,12,young 2,TEst scenario 1,12,young 3,TEst scenario 1,12,young

Error "A CSV file with an incorrect header layout has been imported. Make sure the imported CSV file has unmodified headers."

@dupliaka See #1254 (comment) - it works if the newly created target grid has the same columns as the original one

Nobody expected this.

gitgabrio · 2019-11-04T14:58:31Z

Manual review 8

Validation error appears instead of warning if I remove DMN instance in DMN file that was used in background scenario.
video

@dupliaka
In the attached video you clicked in different areas, with two different error popup.
Anyway, it is expected to have an error and not a simple warning: that scenario can not possible work anymore because it is referring to properties that does not exists anymore. Does this make sense?

gitgabrio · 2019-11-04T15:05:27Z

Manual review 9

Warning "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" instead of dialog of removing outdated object from rule based scenario.

Steps:

Create rule based test scenario

Add an URL object to the model

Add Url property to the Bkg section

Save and reopen

Go to Bkg section
Expect : warning dialog about changed model
Actual: No warnings and message "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" if I click on a header

@dupliaka
Sorry can't follow: what is an "URL" object? Where did you exactly add it? Why/when should warn about "changed model" ?

gitgabrio · 2019-11-04T15:07:10Z

Manual review 10

If user rename Data object that was used in test scenario, then validate it in test scenario and goes to data object again he got "Java file could not be parsed, it won’t be possible to open the Editor tab, use the Source tab instead."

Steps:

Create rule-based test scenario and add a property from data object

Rename that data object

Go back to scenario and validate it 0 it should contain validation error

Open renamed Data object
Expected: data object model opens
Actual: "Java file could not be parsed, it won’t be possible to open the Editor tab, use the Source tab instead."

@dupliaka
@jomarko gives a good explanation. Beside that, it is not part of this PR.

gitgabrio · 2019-11-04T15:12:36Z

Manual review 6
Export of simple test scenario is not working:
Values from export file were not shown
"#",Scenario description,GIVEN,EXPECT "#",Scenario description,Driver,Driver "#",Scenario description,age,status 1,TEst scenario 1,12,young 2,TEst scenario 1,12,young 3,TEst scenario 1,12,young

Error "A CSV file with an incorrect header layout has been imported. Make sure the imported CSV file has unmodified headers."

@dupliaka See #1254 (comment) - it works if the newly created target grid has the same columns as the original one

Nobody expected this.

@dupliaka when you import a csv there is a popup warn about header structure; beside that, this is how it has been implemented. @danielezonca wdyt?
@dupliaka
Anyway, it could be a possible refactor, but it is not related to this PR. Could you please open a specific ticket? Thanks!

jomarko · 2019-11-05T10:55:47Z

@gitgabrio
Manual Review 1 reported as https://issues.jboss.org/browse/DROOLS-4726

jomarko · 2019-11-05T11:01:53Z

@gitgabrio
Manual review 3 reported as https://issues.jboss.org/browse/DROOLS-4727, the message is not explaining that user can not bind facts on Background tab.

dupliaka · 2019-11-05T11:06:29Z

Manual review 9

Warning "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" instead of dialog of removing outdated object from rule based scenario.
Steps:

Create rule based test scenario

Add an URL object to the model

Add Url property to the Bkg section

Save and reopen

Go to Bkg section
Expect : warning dialog about changed model
Actual: No warnings and message "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" if I click on a header

@dupliaka
Sorry can't follow: what is an "URL" object? Where did you exactly add it? Why/when should warn about "changed model" ?

URL is the via items in Data Object tab
https://issues.jboss.org/secure/attachment/12457177/URL%20type.mov

jomarko

@gitgabrio I checked your resolution to my comments to code and manual review comments. as result of this I reported two more jiras. I am not doing any intensive re-review due to my time resources. Thank you

dupliaka · 2019-11-05T11:11:08Z

Manual review 8

Validation error appears instead of warning if I remove DMN instance in DMN file that was used in background scenario.
video

@dupliaka
In the attached video you clicked in different areas, with two different error popup.
Anyway, it is expected to have an error and not a simple warning: that scenario can not possible work anymore because it is referring to properties that does not exists anymore. Does this make sense?

Sorry but it should not show error and after that show the unexpected error after i try to change anything in the document.

gitgabrio · 2019-11-05T11:48:31Z

Manual review 8

Validation error appears instead of warning if I remove DMN instance in DMN file that was used in background scenario.
video

@dupliaka
In the attached video you clicked in different areas, with two different error popup.
Anyway, it is expected to have an error and not a simple warning: that scenario can not possible work anymore because it is referring to properties that does not exists anymore. Does this make sense?

Sorry but it should not show error and after that show the unexpected error after i try to change anything in the document.

@dupliaka
It could be a possible refactor, but it is not related to this PR. Could you please open a specific ticket? Thanks!

dupliaka · 2019-11-05T12:07:10Z

Ok, I gathered the results here https://docs.google.com/spreadsheets/d/1bsQb9_EbOuQFotH41KmfETd8wkQhQU_lgsnKvpnKmF8/edit?usp=sharing
@gitgabrio There only two points left, could you answer it?

dupliaka · 2019-11-05T12:08:42Z

jenkins execute full downstream build

gitgabrio · 2019-11-05T12:21:56Z

Ok, I gathered the results here https://docs.google.com/spreadsheets/d/1bsQb9_EbOuQFotH41KmfETd8wkQhQU_lgsnKvpnKmF8/edit?usp=sharing
@gitgabrio There only two points left, could you answer it?

@dupliaka
One of the question I think is related to DROOLS-4726/DROOLS-4727.
About importing scesim: could you attach the failing scesim here?

gitgabrio · 2019-11-05T13:31:08Z

Manual review 9

Warning "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" instead of dialog of removing outdated object from rule based scenario.
Steps:

Create rule based test scenario

Add an URL object to the model

Add Url property to the Bkg section

Save and reopen

Go to Bkg section
Expect : warning dialog about changed model
Actual: No warnings and message "Command EnableTestToolsCommand failure: ERROR (TypeError) : Cannot read property 'setInstanceAssigned_1_g$' of undefined" if I click on a header

@dupliaka
Sorry can't follow: what is an "URL" object? Where did you exactly add it? Why/when should warn about "changed model" ?

URL is the via items in Data Object tab
https://issues.jboss.org/secure/attachment/12457177/URL%20type.mov

@dupliaka
Just followed the steps you mentioned without issue: is there something else missing?

dupliaka

QE review is finished from my side : https://docs.google.com/spreadsheets/d/1bsQb9_EbOuQFotH41KmfETd8wkQhQU_lgsnKvpnKmF8/edit#gid=0

gitgabrio and others added 12 commits October 18, 2019 15:41

[DROOLS-4648] Move settings from SimulationDescriptor to specific tag.

cd42378

[DROOLS-4648] Start and run. Principal features working

098a9aa

[DROOLS-4648] Adapting merge with master

0c6c3e2

Merge remote-tracking branch 'origin/master' into DROOLS-4648

9af2656

DROOLS-3727: Add temporary kogito related module configuration

4a6659d

[DROOLS-4648] Fixed tests for current iteration

4522076

Merge remote-tracking branch 'origin/master' into DROOLS-4648

95cd70b

[DROOLS-4648] Implementing focus

39acba6

[DROOLS-4648] Implementing focus

477dfa3

[DROOLS-4648] Prepared tab switching

86a8cae

gitgabrio mentioned this pull request Oct 28, 2019

Drools 4648 - Define and Implement a DataModel to hold Background Table Data apache/incubator-kie-drools#2630

Merged

[DROOLS-4648] Fixing/adding tests

a739c28

gitgabrio requested review from dupliaka, yesamer and danielezonca October 28, 2019 18:27

danielezonca reviewed Oct 29, 2019

View reviewed changes

dupliaka reviewed Oct 29, 2019

View reviewed changes

gitgabrio added 3 commits October 29, 2019 13:26

[DROOLS-4648] Following renaming on backend side

cfe9e90

[DROOLS-4648] Clean PR from not-related modifications

f29305b

Merge remote-tracking branch 'origin/master' into DROOLS-4648

60c5d87

danielezonca approved these changes Oct 29, 2019

View reviewed changes

dupliaka reviewed Oct 30, 2019

View reviewed changes

[DROOLS-4648] Fixed as per PR suggestion

024de11

jomarko approved these changes Nov 5, 2019

View reviewed changes

dupliaka approved these changes Nov 5, 2019

View reviewed changes

yesamer removed their request for review November 5, 2019 15:39

danielezonca merged commit 445979d into kiegroup:master Nov 5, 2019

gitgabrio deleted the DROOLS-4648 branch December 2, 2019 11:31

		// TODO {gcardosi} restore after correction on presenter
		// verify(scenarioBackgroundGridWidgetMock, times(1)).setContent(isA(Simulation.class), eq(scenarioSimulationContextLocal.getSettings().getType()));

Drools 4648 Define and Implement a DataModel to hold Background Table Data #1254

Drools 4648 Define and Implement a DataModel to hold Background Table Data #1254

Conversation

gitgabrio commented Oct 28, 2019 • edited

gitgabrio commented Oct 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dupliaka commented Oct 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitgabrio Oct 29, 2019 • edited

Choose a reason for hiding this comment

gitgabrio commented Oct 29, 2019

gitgabrio commented Oct 29, 2019

danielezonca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitgabrio commented Nov 4, 2019

Manual review 01

gitgabrio commented Nov 4, 2019

Manual review 02

gitgabrio commented Nov 4, 2019

Manual review 03

gitgabrio commented Nov 4, 2019 • edited

Manual review 04

gitgabrio commented Nov 4, 2019

Manual Review 05

gitgabrio commented Nov 4, 2019

gitgabrio commented Nov 4, 2019

Manual review 01

gitgabrio commented Nov 4, 2019 • edited

dupliaka commented Nov 4, 2019 • edited

gitgabrio commented Nov 4, 2019 • edited

dupliaka commented Nov 4, 2019

gitgabrio commented Nov 4, 2019

Manual review 8

gitgabrio commented Nov 4, 2019

Manual review 9

gitgabrio commented Nov 4, 2019

gitgabrio commented Nov 4, 2019 • edited

jomarko commented Nov 5, 2019

jomarko commented Nov 5, 2019

dupliaka commented Nov 5, 2019

Manual review 9

jomarko left a comment • edited

Choose a reason for hiding this comment

dupliaka commented Nov 5, 2019

Manual review 8

gitgabrio commented Nov 5, 2019

Manual review 8

dupliaka commented Nov 5, 2019

dupliaka commented Nov 5, 2019

gitgabrio commented Nov 5, 2019

gitgabrio commented Nov 5, 2019

Manual review 9

dupliaka left a comment • edited

Choose a reason for hiding this comment

gitgabrio commented Oct 28, 2019 •

edited

gitgabrio Oct 29, 2019 •

edited

gitgabrio commented Nov 4, 2019 •

edited

gitgabrio commented Nov 4, 2019 •

edited

dupliaka commented Nov 4, 2019 •

edited

gitgabrio commented Nov 4, 2019 •

edited

gitgabrio commented Nov 4, 2019 •

edited

jomarko left a comment •

edited

dupliaka left a comment •

edited