DROOLS-4969: Fixed broken tests after merge of DROOLS-4969 #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
approved these changes
Feb 6, 2020
| @@ -210,8 +210,7 @@ protected CompositeTypeImpl getSingleCompositeWithNestedCollection() { | |||
| */ | |||
| protected CompositeTypeImpl getCompositeCollection() { | |||
| // Complex object retrieve | |||
| CompositeTypeImpl toReturn = new CompositeTypeImpl("compositeNameSpace", COMPOSITE_TYPE_NAME, null); | |||
| toReturn.setCollection(true); | |||
| CompositeTypeImpl toReturn = new CompositeTypeImpl("compositeNameSpace", COMPOSITE_TYPE_NAME, null, true); | |||
jomarko
reviewed
Feb 6, 2020
| @@ -210,8 +210,7 @@ protected CompositeTypeImpl getSingleCompositeWithNestedCollection() { | |||
| */ | |||
| protected CompositeTypeImpl getCompositeCollection() { | |||
| // Complex object retrieve | |||
| CompositeTypeImpl toReturn = new CompositeTypeImpl("compositeNameSpace", COMPOSITE_TYPE_NAME, null); | |||
| toReturn.setCollection(true); | |||
| CompositeTypeImpl toReturn = new CompositeTypeImpl("compositeNameSpace", COMPOSITE_TYPE_NAME, null, true); | |||
There was a problem hiding this comment.
Me personally would implement as:
final boolean isCollection = true;
CompositeTypeImpl toReturn = new CompositeTypeImpl("compositeNameSpace", COMPOSITE_TYPE_NAME, null, isCollection);
jomarko
approved these changes
Feb 6, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
danielezonca
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielezonca @jomarko @tarilabs
Considering the changes https://github.com/kiegroup/drools/pull/2741,
isCollectionboolean must be passed to the constructor ofCompositeTypeImpl, because it's now used to determine the object behavior. UsingsetCollection()method leads to the issue. (It should be handled or, even better, removed)