DROOLS-5104: Compute scenario simulation tabs indexes dynamically #1325
Conversation
|
jenkins execute full downstream build |
| @@ -269,7 +269,9 @@ public void onOverviewSelected() { | |||
| */ | |||
| @Override | |||
| public void addBackgroundPage(final ScenarioGridWidget scenarioGridWidget) { | |||
| kieView.getMultiPage().addPage(BACKGROUND_TAB_INDEX, new PageImpl(scenarioGridWidget, ScenarioSimulationEditorConstants.INSTANCE.backgroundTabTitle()) { | |||
| final MultiPageEditorViewImpl editorMultiPageView = (MultiPageEditorViewImpl) kieView.getMultiPage().getView(); | |||
| final int backgroundPageIndex = editorMultiPageView.getPageIndex(CommonConstants.INSTANCE.EditTabTitle()) + 1; | |||
There was a problem hiding this comment.
We can avoid magical numbers by using ++
There was a problem hiding this comment.
@dupliaka I was not able to apply ++ operator, because it is need to use it just with non final variables. However I decided at least update formatting == I extracted some constants to variables to not exceed maximum amount of characters per line.
|
SonarCloud Quality Gate failed.
|
|
@rsynek hello, may I ask you for help? Sonar is reporting zero coverage for new lines in this PR, however it is not true. Could you advice what configuration I should check and where? Idea in my mind, aren't some modules black listed, or vice versa just some white listed? |
|
@jomarko I think there is something wrong with the repository. The coverage fell to 0.0% on January 23rd https://sonarcloud.io/project/activity?custom_metrics=coverage&graph=custom&id=org.drools%3Adrools-wb |
|
@kiegroup/gatekeepers please merge |
For more details see: https://issues.redhat.com/browse/DROOLS-5104