Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-5171 Remove unused dependencies #1336

Merged
merged 1 commit into from Mar 19, 2020

Conversation

jomarko
Copy link

@jomarko jomarko commented Mar 17, 2020

@jomarko
Copy link
Author

jomarko commented Mar 17, 2020

jenkins execute full downstream build

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@dupliaka dupliaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thanks!
One querstion:
Could you tell me why did you left this depedencies:

[WARNING]    org.uberfire:uberfire-message-console-client:jar:7.35.0-SNAPSHOT:provided
[WARNING]    org.kie.workbench.widgets:kie-wb-config-resource-widget:jar:7.35.0-SNAPSHOT:provided

mvn told me it is not used too.

@jomarko
Copy link
Author

jomarko commented Mar 19, 2020

@dupliaka , thank you for feedback. This time I was not using any mvn command just my knowledge about kiegroup code base. dashbuilder was pretty suspicious for me and just tried to remove it. I can definitely have a look on dependencies you mention also. Just question what maven command do you use, I use mvn dependency:analyze that doesn't give always 100% correct results.

@dupliaka
Copy link
Member

dupliaka commented Mar 19, 2020

@dupliaka , thank you for feedback. This time I was not using any mvn command just my knowledge about kiegroup code base. dashbuilder was pretty suspicious for me and just tried to remove it. I can definitely have a look on dependencies you mention also. Just question what maven command do you use, I use mvn dependency:analyze that doesn't give always 100% correct results.

Well you can use dependency:tree to figure out is that is not used by any of the component
Plus from my knowledge dependency:analyze is not capable to take in account only runtime dependencies.

From my side I am not so experienced in the project so that is only feedback I can give, so if you feel that is unnecessary, then ignore my comment)

@jomarko
Copy link
Author

jomarko commented Mar 19, 2020

@dupliaka I reported task for me to investigate those two you mentioned https://issues.redhat.com/browse/DROOLS-5185

@jomarko
Copy link
Author

jomarko commented Mar 19, 2020

@kiegroup/gatekeepers please merge

@mareknovotny mareknovotny merged commit ca6a5a2 into kiegroup:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants