New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-2189: Columns widths are not correctly saved in Scesim Editor KOGITO #1366
Conversation
jenkins retest this please |
jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Columns width does not change if user reopens saved file
- Removing columns moves other columns for table ajasting
- Scroll is extending to be able to scroll the table with modified columns width
@yesamer two questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@dupliaka I think those are issues on appformer side |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Are you sure about it? |
@dupliaka I meant appformer Kogito version. The widget which contains the grid is managed on appformer code. Please try to reproduce the same issues on Kogito VSCode without my changes, they should be present as well Anyway, I agree with your choice to open a new ticket for those issues, we can analyze it with the support of appformer team. |
Doesn't matter, I updated all of the dependency, and it seems like it is finally works for me, thanks! |
@danielezonca @dupliaka can you please review and test it?
I noticed that
columnWidth
changes were not saved in VSCode Kogito Editor. Scope of this PR is to let this mechanism works.wrappedSave
method was removed because not called anywhere.https://issues.redhat.com/browse/KOGITO-2189