Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-2189: Columns widths are not correctly saved in Scesim Editor KOGITO #1366

Merged
merged 3 commits into from May 15, 2020

Conversation

yesamer
Copy link
Member

@yesamer yesamer commented May 14, 2020

@danielezonca @dupliaka can you please review and test it?

I noticed that columnWidth changes were not saved in VSCode Kogito Editor. Scope of this PR is to let this mechanism works.

wrappedSave method was removed because not called anywhere.

https://issues.redhat.com/browse/KOGITO-2189

@yesamer
Copy link
Member Author

yesamer commented May 14, 2020

jenkins retest this please

@yesamer yesamer marked this pull request as ready for review May 14, 2020 13:34
@yesamer
Copy link
Member Author

yesamer commented May 14, 2020

jenkins retest this please

Copy link
Member

@dupliaka dupliaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Columns width does not change if user reopens saved file
  • Removing columns moves other columns for table ajasting
  • Scroll is extending to be able to scroll the table with modified columns width

@dupliaka
Copy link
Member

dupliaka commented May 14, 2020

@yesamer two questions:

Copy link
Member

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yesamer
Copy link
Member Author

yesamer commented May 14, 2020

@dupliaka I think those are issues on appformer side

@sonarcloud
Copy link

sonarcloud bot commented May 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dupliaka
Copy link
Member

dupliaka commented May 15, 2020

@dupliaka I think those are issues on appformer side

Are you sure about it?
I checked 7.37 version of BC master and drag and drop is working there but after your PR that changes dramatically. Could you please provide me some details why do you think so?

@yesamer
Copy link
Member Author

yesamer commented May 15, 2020

@dupliaka I meant appformer Kogito version. The widget which contains the grid is managed on appformer code. Please try to reproduce the same issues on Kogito VSCode without my changes, they should be present as well

Anyway, I agree with your choice to open a new ticket for those issues, we can analyze it with the support of appformer team.

@dupliaka
Copy link
Member

@dupliaka I meant appformer Kogito version. The widget which contains the grid is managed on appformer code. Please try to reproduce the same issues on Kogito VSCode without my changes, they should be present as well

Anyway, I agree with your choice to open a new ticket for those issues, we can analyze it with the support of appformer team.

Doesn't matter, I updated all of the dependency, and it seems like it is finally works for me, thanks!
Approved

@danielezonca danielezonca merged commit c974662 into kiegroup:master May 15, 2020
@yesamer yesamer deleted the KOGITO-2189 branch May 15, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants