Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.39.x] DROOLS-5457 : XLS Decision table: File indexed before content is saved #1406

Merged
merged 1 commit into from Aug 5, 2020

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented Aug 3, 2020

@Rikkola Rikkola marked this pull request as ready for review August 3, 2020 06:46
@Rikkola Rikkola changed the title DROOLS-5457 : XLS Decision table: File indexed before content is saved [7.39.x] DROOLS-5457 : XLS Decision table: File indexed before content is saved Aug 3, 2020
@Rikkola
Copy link
Member Author

Rikkola commented Aug 3, 2020

@vpellegrino @jomarko master PR is still trying to get green, but need to start running the builds if I want these in in time.

Copy link

@vpellegrino vpellegrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you @Rikkola

@Rikkola
Copy link
Member Author

Rikkola commented Aug 5, 2020

@kiegroup/gatekeepers Can I get a merge please.

@mareknovotny
Copy link
Member

waiting on proper PR CI to finish, the Linux - Pull Request ()* is from previous CI job which erroneously didn't run tests at all

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@mareknovotny mareknovotny merged commit 9273ab4 into kiegroup:7.39.x Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants