DROOLS-2103: Test scenario using Numerical types #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jomarko This PR needs some love before we review :-) |
jomarko
force-pushed
the
DROOLS-2103-NumericalTypesInScenario
branch
from
04ec6a8
to
68796c1
Compare
jomarko
changed the title
|
@manstis PR updated with my love. |
manstis
approved these changes
Nov 7, 2017
Rikkola
approved these changes
Nov 7, 2017
This PR fire rules with BigInteger and BigDecimal fact fields and checks mathematical operations with these fields in the test scenario.
jomarko
force-pushed
the
DROOLS-2103-NumericalTypesInScenario
branch
from
68796c1
to
65f4937
Compare
|
@manstis it could be safe to get this in. |
|
@jomarko Hopefully "it should be safe"... and not "could be safe" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #703