Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing Quarkus 3 jobs #13

Closed
wants to merge 6 commits into from
Closed

removing Quarkus 3 jobs #13

wants to merge 6 commits into from

Conversation

mareknovotny
Copy link
Member

Thank you for submitting this pull request

NOTE!: Double check the target branch for this PR.
The default is main so it will target Drools 8 / Kogito.
If this PR is not strictly related to drools and kogito project in drools.git, it should probably target 7.xas a branch

Ports If a forward-port or a backport is needed, paste the forward port PR here

link

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • an upstream build please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@@ -198,13 +190,13 @@ setupSpecificBuildChainNightlyJob('native', nightlyJobParamsGetter)
setupSpecificBuildChainNightlyJob('sonarcloud', nightlyJobParamsGetter)
setupQuarkusIntegrationJob('quarkus-main', nightlyJobParamsGetter)
setupQuarkusIntegrationJob('quarkus-branch', nightlyJobParamsGetter)
setupQuarkusIntegrationJob('quarkus-lts', nightlyJobParamsGetter)
setupQuarkusIntegrationJob('native-lts', nightlyJobParamsGetter)
//setupQuarkusIntegrationJob('quarkus-lts', nightlyJobParamsGetter)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you would like to keep LTS checks because this is the productized ones or ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTS is now in upstream by default, so we basically don't need to have a special LTS job imho

@radtriste
Copy link

Going to each jobs.groovy to disable jobs will take time and a lot of PRs as you would need to update all repositories.

ok to my suggestion is to disable all environments instead of commenting, that latter change may break the seed generation.
My suggestion: Go to branch.yaml file and add enabled: false to each of the environment.
There is also a way to disable job_types.
You can follow this commit change and apply it similarly to drools, kogito-pipelines and optaplanner and apply to it with your desires.

@mareknovotny
Copy link
Member Author

thanks @radtriste for advice, the only problem i can see is that we still want to keep CI pipelines for branches maybe even for some pipelines also for main branches. I probably need to change on these the notification from Zulip to mailing list to not disturb Apache upstream channels.

@radtriste
Copy link

@mareknovotny Updating the branch.yaml on main branch will only affect jobs for the main branch. Other branches should not be affected.
I you want to update the mail for notifications and send it to Red Hat email instead of Zulip, this is to be directly into the Credentials from Jenkins (KOGITO_CI_EMAIL_TO and OPTAPLANNER_CI_EMAIL_TO)

@mareknovotny
Copy link
Member Author

closing in favour of #19

@mareknovotny mareknovotny deleted the ci-quarkus3-removal branch February 1, 2024 15:47
nmirasch pushed a commit to nmirasch/drools that referenced this pull request Feb 22, 2024
…le execution in multi threads (kiegroup#13)

* [DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… (apache#4771) (apache#4823)

* [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator
- Test case only

* [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator
- Fix

* - test method name change
- lookAheadIgnoringSpaces to return a Character

* Additional secondary super cache issue
- Bump Version
- Added benchmark to drools
- Fixed secondary super cache on AgendaItem
- Fix ObjectSinkNode, LeftTupleSinkNode
- Fix ClassAwareObjectStore
- Fix TerminalNode
- Revert "Added benchmark to drools"
- Revert "Bump Version"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants