Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANNER-2044 pmebuild buildConfigAdditionalVariables argument added #1378

Merged
merged 2 commits into from Jun 30, 2020
Merged

PLANNER-2044 pmebuild buildConfigAdditionalVariables argument added #1378

merged 2 commits into from Jun 30, 2020

Conversation

Ginxo
Copy link
Contributor

@Ginxo Ginxo commented Jun 30, 2020 •
edited

https://issues.redhat.com/browse/PLANNER-2044
depends on kiegroup/jenkins-pipeline-shared-libraries#67
The idea is to read the project to build 7.x branch from ./script/branched-7-repository-list.txt file

@Ginxo Ginxo mentioned this pull request Jun 30, 2020
Merged
@Ginxo Ginxo marked this pull request as draft June 30, 2020 09:40
@Ginxo Ginxo marked this pull request as ready for review June 30, 2020 10:20
ge0ffrey
ge0ffrey approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@ge0ffrey ge0ffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Do note that the script/branched-7-repository-list.txt will conflict with the other PR, which should be merged first I think.

mareknovotny
mareknovotny approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mareknovotny mareknovotny merged commit a78da52 into kiegroup:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ge0ffrey ge0ffrey ge0ffrey approved these changes

@mareknovotny mareknovotny mareknovotny approved these changes

@mbiarnes mbiarnes Awaiting requested review from mbiarnes

@winklerm winklerm Awaiting requested review from winklerm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Ginxo @ge0ffrey @mareknovotny